diff options
| author | Jozef Lawrynowicz <jozef.l@mittosystems.com> | 2020-08-28 13:56:53 +0100 |
|---|---|---|
| committer | Jozef Lawrynowicz <jozef.l@mittosystems.com> | 2020-08-28 14:01:10 +0100 |
| commit | 64b63c2993db8606334f6f0852b4e7bb70b5682a (patch) | |
| tree | ac258fac488e748215125eb78ed3e556e8b627c5 /ld/scripttempl | |
| parent | 87870682f3a7fc29208026dfa4aac75b195cc990 (diff) | |
| download | fsf-binutils-gdb-64b63c2993db8606334f6f0852b4e7bb70b5682a.zip fsf-binutils-gdb-64b63c2993db8606334f6f0852b4e7bb70b5682a.tar.gz fsf-binutils-gdb-64b63c2993db8606334f6f0852b4e7bb70b5682a.tar.bz2 | |
MSP430: Fix alignment of __*_array_start symbols in default linker script
__{preinit,init,fini}_array_start symbols must be word aligned in
linker scripts. If the section preceding the __*_array_start symbol
has an odd size, then a NULL byte will be present between the start
symbol and the .*_array section itself, when the section gets
automatically word-aligned.
This results in a branch to an invalid address when the CRT startup
code tries to run through the functions listed in the array sections.
Some MSP430 linker scripts do not align the __*_array start symbols, so
this added warning will catch that problem and help the user avoid
the potential incorrect execution of the program.
ld/ChangeLog:
* emultempl/msp430.em (input_section_exists): New.
(check_array_section_alignment): New.
(gld${EMULATION_NAME}_finish): New.
* scripttempl/elf32msp430.sc: Add ALIGN directives before the
definition of __*_array_start symbols.
* testsuite/ld-msp430-elf/finiarray-warn.ld: New test.
* testsuite/ld-msp430-elf/finiarray-warn.r: New test.
* testsuite/ld-msp430-elf/initarray-nowarn.ld: New test.
* testsuite/ld-msp430-elf/initarray-warn.ld: New test.
* testsuite/ld-msp430-elf/initarray-warn.r: New test.
* testsuite/ld-msp430-elf/initarray.s: New test.
* testsuite/ld-msp430-elf/msp430-elf.exp: Run new tests.
* testsuite/ld-msp430-elf/preinitarray-warn.ld: New test.
* testsuite/ld-msp430-elf/preinitarray-warn.r: New test.
Diffstat (limited to 'ld/scripttempl')
| -rw-r--r-- | ld/scripttempl/elf32msp430.sc | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/ld/scripttempl/elf32msp430.sc b/ld/scripttempl/elf32msp430.sc index f9ee9ff..4206d79 100644 --- a/ld/scripttempl/elf32msp430.sc +++ b/ld/scripttempl/elf32msp430.sc @@ -208,15 +208,18 @@ SECTIONS KEEP (*(.gcc_except_table)) *(.gcc_except_table.*) + . = ALIGN(2); PROVIDE (__preinit_array_start = .); KEEP (*(.preinit_array)) PROVIDE (__preinit_array_end = .); + . = ALIGN(2); PROVIDE (__init_array_start = .); KEEP (*(SORT(.init_array.*))) KEEP (*(.init_array)) PROVIDE (__init_array_end = .); + . = ALIGN(2); PROVIDE (__fini_array_start = .); KEEP (*(.fini_array)) KEEP (*(SORT(.fini_array.*))) |