diff options
| author | Pedro Alves <palves@redhat.com> | 2017-04-05 19:21:33 +0100 |
|---|---|---|
| committer | Pedro Alves <palves@redhat.com> | 2017-04-05 19:21:33 +0100 |
| commit | f995bbe8e62fdb5607acb1ee127240cfe50d2b8f (patch) | |
| tree | a4655a0335b4f97405a4cd3316e954cda2fdd421 /include | |
| parent | 0ad9d8c73486e60c5a4963c1b7a0ea7063d69cd2 (diff) | |
| download | fsf-binutils-gdb-f995bbe8e62fdb5607acb1ee127240cfe50d2b8f.zip fsf-binutils-gdb-f995bbe8e62fdb5607acb1ee127240cfe50d2b8f.tar.gz fsf-binutils-gdb-f995bbe8e62fdb5607acb1ee127240cfe50d2b8f.tar.bz2 | |
-Wwrite-strings: Constify struct disassemble_info's disassembler_options field
The memory disassemble_info::disassembler_options points to is always
owned by the client. I.e., that field is an non-owning, observing
pointer. Thus const makes sense.
Are the include/ and opcodes/ bits OK?
Tested on x86_64 Fedora 23, built with --enable-targets=all.
include/ChangeLog:
2017-04-05 Pedro Alves <palves@redhat.com>
* dis-asm.h (disassemble_info) <disassembler_options>: Now a
"const char *".
(next_disassembler_option): Constify.
opcodes/ChangeLog:
2017-04-05 Pedro Alves <palves@redhat.com>
* arc-dis.c (parse_option, parse_disassembler_options): Constify.
* arm-dis.c (parse_arm_disassembler_options): Constify.
* ppc-dis.c (powerpc_init_dialect): Constify local.
* vax-dis.c (parse_disassembler_options): Constify.
gdb/ChangeLog:
2017-04-05 Pedro Alves <palves@redhat.com>
* arm-tdep.c (show_disassembly_style_sfunc): Constify local.
* disasm.c (set_disassembler_options): Constify local.
* i386-tdep.c (i386_print_insn): Remove cast and FIXME comment.
Diffstat (limited to 'include')
| -rw-r--r-- | include/ChangeLog | 6 | ||||
| -rw-r--r-- | include/dis-asm.h | 8 |
2 files changed, 10 insertions, 4 deletions
diff --git a/include/ChangeLog b/include/ChangeLog index fa0f3de..956e252 100644 --- a/include/ChangeLog +++ b/include/ChangeLog @@ -1,3 +1,9 @@ +2017-04-05 Pedro Alves <palves@redhat.com> + + * dis-asm.h (disassemble_info) <disassembler_options>: Now a + "const char *". + (next_disassembler_option): Constify. + 2017-04-04 H.J. Lu <hongjiu.lu@intel.com> * elf/common.h (PT_GNU_MBIND_NUM): New. diff --git a/include/dis-asm.h b/include/dis-asm.h index f054450..2ed3d7e 100644 --- a/include/dis-asm.h +++ b/include/dis-asm.h @@ -210,7 +210,7 @@ typedef struct disassemble_info bfd_vma target2; /* Second target address for dref2 */ /* Command line options specific to the target disassembler. */ - char * disassembler_options; + const char *disassembler_options; /* If non-zero then try not disassemble beyond this address, even if there are values left in the buffer. This address is the address @@ -369,10 +369,10 @@ extern char *remove_whitespace_and_extra_commas (char *); extern int disassembler_options_cmp (const char *, const char *); /* A helper function for FOR_EACH_DISASSEMBLER_OPTION. */ -static inline char * -next_disassembler_option (char *options) +static inline const char * +next_disassembler_option (const char *options) { - char *opt = strchr (options, ','); + const char *opt = strchr (options, ','); if (opt != NULL) opt++; return opt; |