aboutsummaryrefslogtreecommitdiff
path: root/gdbsupport
diff options
context:
space:
mode:
authorKamil Rytarowski <n54@gmx.com>2020-09-23 04:20:05 +0200
committerKamil Rytarowski <n54@gmx.com>2020-10-02 00:38:12 +0200
commite2a2a24a8e78427ff8667d625f5befbe88c328bb (patch)
treea2cc2e7cd4bf621d7a18ecde02f77d1ceec9cd64 /gdbsupport
parent1eb6eb795fd3479c97d8aadc4f70d6afad5f8511 (diff)
downloadfsf-binutils-gdb-e2a2a24a8e78427ff8667d625f5befbe88c328bb.zip
fsf-binutils-gdb-e2a2a24a8e78427ff8667d625f5befbe88c328bb.tar.gz
fsf-binutils-gdb-e2a2a24a8e78427ff8667d625f5befbe88c328bb.tar.bz2
Preinitialize the sockaddr_un variable to zero
Don't pass random sun_len for the BSD's, zero the whole structure as recommended for portability. Reported by Coverity. gdbsupport/ChangeLog: * agent.cc (gdb_connect_sync_socket): Preinitialize addr with zeros.
Diffstat (limited to 'gdbsupport')
-rw-r--r--gdbsupport/ChangeLog5
-rw-r--r--gdbsupport/agent.cc2
2 files changed, 5 insertions, 2 deletions
diff --git a/gdbsupport/ChangeLog b/gdbsupport/ChangeLog
index 91435ff..216fad1 100644
--- a/gdbsupport/ChangeLog
+++ b/gdbsupport/ChangeLog
@@ -1,3 +1,7 @@
+2020-10-01 Kamil Rytarowski <n54@gmx.com>
+
+ * agent.cc (gdb_connect_sync_socket): Preinitialize addr with zeros.
+
2020-09-29 Pedro Alves <pedro@palves.net>
* valid-expr.h (CHECK_VALID_EXPR_INT): Make archetype a template
@@ -327,4 +331,3 @@
* acinclude.m4, aclocal.m4, config.in, configure, configure.ac,
Makefile.am, Makefile.in, README: New files.
* Moved from ../gdb/gdbsupport/
-
diff --git a/gdbsupport/agent.cc b/gdbsupport/agent.cc
index b4127ff..9588e1f 100644
--- a/gdbsupport/agent.cc
+++ b/gdbsupport/agent.cc
@@ -138,7 +138,7 @@ static int
gdb_connect_sync_socket (int pid)
{
#ifdef HAVE_SYS_UN_H
- struct sockaddr_un addr;
+ struct sockaddr_un addr = {};
int res, fd;
char path[UNIX_PATH_MAX];