diff options
author | Simon Marchi <simon.marchi@ericsson.com> | 2015-06-02 15:32:40 -0400 |
---|---|---|
committer | Simon Marchi <simon.marchi@ericsson.com> | 2015-06-02 15:32:57 -0400 |
commit | 3b462ec2bedca7392bf4720db44fdf2a46ad8b4d (patch) | |
tree | 00f38e40bcab9efa75a154ad7b8c3f57f2e8c407 /gdb | |
parent | 9c7fe3c5c2c9e4c3571c253cf77341e3f6adf94c (diff) | |
download | fsf-binutils-gdb-3b462ec2bedca7392bf4720db44fdf2a46ad8b4d.zip fsf-binutils-gdb-3b462ec2bedca7392bf4720db44fdf2a46ad8b4d.tar.gz fsf-binutils-gdb-3b462ec2bedca7392bf4720db44fdf2a46ad8b4d.tar.bz2 |
Fix =thread-exited not showing up when detaching (PR 15564)
I sent a patch in 2013 for this (incorrectly named =thread-created):
https://cygwin.com/ml/gdb-patches/2013-06/msg00129.html
Tom Tromey was ok with the change, but suggested to add a test as well.
Then I forgot about this patch until today. So here it is again, with the
corresponding test.
The problem is that the =thread-exited event does not appear when detaching
from a local process. It does appear with remote though. It's not a really
big deal, but I'd like it to be consistent.
Tested with local and remote Linux on my Ubuntu 14.04.
gdb/ChangeLog:
PR gdb/15564
* inferior.c (detach_inferior): Call exit_inferior_1 with silent = 0.
gdb/testsuite/ChangeLog:
PR gdb/15564
* gdb.mi/mi-detach.exp: New file.
Diffstat (limited to 'gdb')
-rw-r--r-- | gdb/ChangeLog | 5 | ||||
-rw-r--r-- | gdb/inferior.c | 2 | ||||
-rw-r--r-- | gdb/testsuite/ChangeLog | 5 | ||||
-rw-r--r-- | gdb/testsuite/gdb.mi/mi-detach.exp | 35 |
4 files changed, 46 insertions, 1 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index eca000f..37d619b 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2015-06-02 Simon Marchi <simon.marchi@ericsson.com> + + PR gdb/15564 + * inferior.c (detach_inferior): Call exit_inferior_1 with silent = 0. + 2015-06-02 Yao Qi <yao.qi@linaro.org> * i386-linux-nat.c: Include linux-nat.h. diff --git a/gdb/inferior.c b/gdb/inferior.c index ba320b5..d0783d3 100644 --- a/gdb/inferior.c +++ b/gdb/inferior.c @@ -310,7 +310,7 @@ detach_inferior (int pid) { struct inferior *inf = find_inferior_pid (pid); - exit_inferior_1 (inf, 1); + exit_inferior_1 (inf, 0); if (print_inferior_events) printf_unfiltered (_("[Inferior %d detached]\n"), pid); diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 5477f6c..c4f61a0 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2015-06-02 Simon Marchi <simon.marchi@ericsson.com> + + PR gdb/15564 + * gdb.mi/mi-detach.exp: New file. + 2015-06-01 Jan Kratochvil <jan.kratochvil@redhat.com> PR symtab/18392 diff --git a/gdb/testsuite/gdb.mi/mi-detach.exp b/gdb/testsuite/gdb.mi/mi-detach.exp new file mode 100644 index 0000000..88759a9 --- /dev/null +++ b/gdb/testsuite/gdb.mi/mi-detach.exp @@ -0,0 +1,35 @@ +# Copyright 2015 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +# Test that detaching from the inferior produces the right MI records. + +load_lib mi-support.exp +set MIFLAGS "-i=mi" + +gdb_exit +if [mi_gdb_start] { + continue +} + +standard_testfile basics.c + +if {[build_executable $testfile.exp $testfile $srcfile {debug}] == -1} { + untested mi-detach.exp + return -1 +} + +mi_run_to_main + +mi_gdb_test "-target-detach" "=thread-exited,id=\"1\".*=thread-group-exited,id=\"i1\".*" "detach" |