aboutsummaryrefslogtreecommitdiff
path: root/gdb
diff options
context:
space:
mode:
authorTom Tromey <tom@tromey.com>2020-10-12 15:53:16 -0600
committerTom Tromey <tom@tromey.com>2020-10-12 20:18:48 -0600
commiteda214cec17472e7383b8aaf17f6a065b0be4a1e (patch)
tree733232ddea15a84e73ef3094a81a8614ae2864f8 /gdb
parent91840ee38a1114bc02120935bf73dd5acda3b062 (diff)
downloadfsf-binutils-gdb-eda214cec17472e7383b8aaf17f6a065b0be4a1e.zip
fsf-binutils-gdb-eda214cec17472e7383b8aaf17f6a065b0be4a1e.tar.gz
fsf-binutils-gdb-eda214cec17472e7383b8aaf17f6a065b0be4a1e.tar.bz2
Remove clear_section_table
The call to clear_section_table in ~program_space is now clearly not needed -- the section table will clear itself. This patch removes this call and then inlines the one remaining call to clear_section_table. gdb/ChangeLog 2020-10-12 Tom Tromey <tom@tromey.com> * progspace.c (program_space::~program_space): Don't call clear_section_table. * exec.h (clear_section_table): Don't declare. * exec.c (exec_target::close): Update. (clear_section_table): Remove.
Diffstat (limited to 'gdb')
-rw-r--r--gdb/ChangeLog8
-rw-r--r--gdb/exec.c10
-rw-r--r--gdb/exec.h4
-rw-r--r--gdb/progspace.c1
4 files changed, 9 insertions, 14 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 6cf0b26..849bfe2 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,13 @@
2020-10-12 Tom Tromey <tom@tromey.com>
+ * progspace.c (program_space::~program_space): Don't call
+ clear_section_table.
+ * exec.h (clear_section_table): Don't declare.
+ * exec.c (exec_target::close): Update.
+ (clear_section_table): Remove.
+
+2020-10-12 Tom Tromey <tom@tromey.com>
+
* exec.c (add_target_sections_of_objfile): Simplify.
2020-10-12 Tom Tromey <tom@tromey.com>
diff --git a/gdb/exec.c b/gdb/exec.c
index 43385fe..ab47757 100644
--- a/gdb/exec.c
+++ b/gdb/exec.c
@@ -183,7 +183,7 @@ exec_target::close ()
for (struct program_space *ss : program_spaces)
{
set_current_program_space (ss);
- clear_section_table (current_target_sections);
+ current_target_sections->sections.clear ();
exec_close ();
}
}
@@ -577,14 +577,6 @@ file_command (const char *arg, int from_tty)
}
-/* See exec.h. */
-
-void
-clear_section_table (struct target_section_table *table)
-{
- table->sections.clear ();
-}
-
/* Builds a section table, given args BFD, TABLE. */
target_section_table
diff --git a/gdb/exec.h b/gdb/exec.h
index 75177dd..f28a033 100644
--- a/gdb/exec.h
+++ b/gdb/exec.h
@@ -38,10 +38,6 @@ struct objfile;
extern target_section_table build_section_table (struct bfd *);
-/* Remove all entries from TABLE. */
-
-extern void clear_section_table (struct target_section_table *table);
-
/* The current inferior is a child vforked and its program space is
shared with its parent. This pushes the exec target on the
current/child inferior's target stack if there are sections in the
diff --git a/gdb/progspace.c b/gdb/progspace.c
index 3f51216..67ea8bd 100644
--- a/gdb/progspace.c
+++ b/gdb/progspace.c
@@ -154,7 +154,6 @@ program_space::~program_space ()
clear_symtab_users (SYMFILE_DEFER_BP_RESET);
if (!gdbarch_has_shared_address_space (target_gdbarch ()))
free_address_space (this->aspace);
- clear_section_table (&this->target_sections);
clear_program_space_solib_cache (this);
/* Discard any data modules have associated with the PSPACE. */
program_space_free_data (this);