diff options
| author | Andrew Cagney <cagney@redhat.com> | 2002-11-15 20:55:45 +0000 |
|---|---|---|
| committer | Andrew Cagney <cagney@redhat.com> | 2002-11-15 20:55:45 +0000 |
| commit | d741b867bb66a2034e5462fa90f42cc3c349709e (patch) | |
| tree | 6bebf61096d4d515cc57f44182e807a1155a53e6 /gdb | |
| parent | 82d03c99f5af1e1b3287b6bf5e1e25f552326d10 (diff) | |
| download | fsf-binutils-gdb-d741b867bb66a2034e5462fa90f42cc3c349709e.zip fsf-binutils-gdb-d741b867bb66a2034e5462fa90f42cc3c349709e.tar.gz fsf-binutils-gdb-d741b867bb66a2034e5462fa90f42cc3c349709e.tar.bz2 | |
2002-11-15 Andrew Cagney <ac131313@redhat.com>
* complaints.h: Add comment explaining how to eliminate a
deprecated_complain call.
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/ChangeLog | 5 | ||||
| -rw-r--r-- | gdb/complaints.h | 20 |
2 files changed, 21 insertions, 4 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index cddda95..4a8b11e 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2002-11-15 Andrew Cagney <ac131313@redhat.com> + + * complaints.h: Add comment explaining how to eliminate a + deprecated_complain call. + 2002-11-15 David Carlton <carlton@math.stanford.edu> * printcmd.c: Remove #include "disasm.h". diff --git a/gdb/complaints.h b/gdb/complaints.h index 159dcd1..f43feb0 100644 --- a/gdb/complaints.h +++ b/gdb/complaints.h @@ -53,12 +53,24 @@ extern void clear_complaints (struct complaints **complaints, /* Deprecated interfaces to keep the old code working (until it is all converted to the above). Existing code such as: - struct deprecated_complaint msg = { "msg", 0, 0 }; - complaint (&msg); + struct deprecated_complaint msg = { "msg 0x%08x[sic]", 0, 0 }; + deprecated_complain (&msg, addr); - should be replaced by: + should be replaced by either the new call (for the singular case): - complaint (&symtab_complaints, __FILE__, __LINE__, "msg"); + complaint (&symtab_complaints, "msg 0x%s", paddr (addr)); + + or with a wrapper function (for the many-of case): + + msg_complaint (CORE_ADDR addr) + { complaint (&symtab_complaints, "msg 0x%s", paddr (addr)); } + ... + msg_complaint (addr); + + Yes, the typo is intentional. The motivation behind this interface + change is to eliminate all possability of this problem re-occuring + (it has occured in the past and no one is sure that it isn't + present now). Support for complaining about things in the symbol file that aren't catastrophic. |