diff options
| author | Tom Tromey <tom@tromey.com> | 2023-01-11 16:52:38 -0700 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2023-01-13 13:18:57 -0700 |
| commit | d394684d5531ea85fc347d68910bed858880f2e0 (patch) | |
| tree | c243d09e6986451b924a5d48277ba1ec96f8016b /gdb | |
| parent | af4c1c9168866db3ee4c2906f17fc4204adff1f7 (diff) | |
| download | fsf-binutils-gdb-d394684d5531ea85fc347d68910bed858880f2e0.zip fsf-binutils-gdb-d394684d5531ea85fc347d68910bed858880f2e0.tar.gz fsf-binutils-gdb-d394684d5531ea85fc347d68910bed858880f2e0.tar.bz2 | |
Fix latent bug in default_prompt_gdb_start
default_prompt_gdb_start mimics default_gdb_start, but does not set
the use_gdb_stub global. This caused one Python test to work only
because it used the ordinary gdb_start before later using
default_prompt_gdb_start.
This patch updates default_prompt_gdb_start to set this global as
well.
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/testsuite/lib/prompt.exp | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/gdb/testsuite/lib/prompt.exp b/gdb/testsuite/lib/prompt.exp index a7c34fa..56cafa4 100644 --- a/gdb/testsuite/lib/prompt.exp +++ b/gdb/testsuite/lib/prompt.exp @@ -24,6 +24,7 @@ # uses pass if it sees $gdb_prompt, and fail if it sees $gdb_prompt_fail. # proc default_prompt_gdb_start { } { + global use_gdb_stub global GDB global INTERNAL_GDBFLAGS GDBFLAGS global gdb_prompt @@ -31,7 +32,17 @@ proc default_prompt_gdb_start { } { global timeout global gdb_spawn_id + # Set the default value, it may be overriden later by specific testfile. + # + # Use `set_board_info use_gdb_stub' for the board file to flag the inferior + # is already started after connecting and run/attach are not supported. + # This is used for the "remote" protocol. After GDB starts you should + # check global $use_gdb_stub instead of the board as the testfile may force + # a specific different target protocol itself. + set use_gdb_stub [target_info exists use_gdb_stub] + verbose "Spawning $GDB $INTERNAL_GDBFLAGS $GDBFLAGS" + gdb_write_cmd_file "$GDB $INTERNAL_GDBFLAGS $GDBFLAGS" if [info exists gdb_spawn_id] { return 0 |