diff options
| author | Doug Evans <xdje42@gmail.com> | 2014-09-08 20:47:57 -0700 |
|---|---|---|
| committer | Doug Evans <xdje42@gmail.com> | 2014-09-08 20:47:57 -0700 |
| commit | d81412aa4b2669d108de0b4e1d8f881cedebd8a9 (patch) | |
| tree | 01e5a9329bd3b1d70fd35e10c7b39ee4e44a08c0 /gdb | |
| parent | 4c122fc3154566369237c6194def4bd88a074f7e (diff) | |
| download | fsf-binutils-gdb-d81412aa4b2669d108de0b4e1d8f881cedebd8a9.zip fsf-binutils-gdb-d81412aa4b2669d108de0b4e1d8f881cedebd8a9.tar.gz fsf-binutils-gdb-d81412aa4b2669d108de0b4e1d8f881cedebd8a9.tar.bz2 | |
Replace use of magic number with named constant.
gdb/ChangeLog:
* guile/scm-cmd.c (gdbscm_parse_command_name): Replace magic number
with named constant. Fix style of pointer comparison.
* python/py-cmd.c (gdbpy_parse_command_name): Ditto.
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/ChangeLog | 6 | ||||
| -rw-r--r-- | gdb/guile/scm-cmd.c | 2 | ||||
| -rw-r--r-- | gdb/python/py-cmd.c | 2 |
3 files changed, 8 insertions, 2 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 59536c6..ad5ef6f 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2014-09-08 Doug Evans <xdje42@gmail.com> + + * guile/scm-cmd.c (gdbscm_parse_command_name): Replace magic number + with named constant. Fix style of pointer comparison. + * python/py-cmd.c (gdbpy_parse_command_name): Ditto. + 2014-09-07 Gabriel Krisman Bertazi <gabriel@krisman.be> PR gdb/17035 diff --git a/gdb/guile/scm-cmd.c b/gdb/guile/scm-cmd.c index 54bed2c..2c4b2f8 100644 --- a/gdb/guile/scm-cmd.c +++ b/gdb/guile/scm-cmd.c @@ -531,7 +531,7 @@ gdbscm_parse_command_name (const char *name, prefix_text2 = prefix_text; elt = lookup_cmd_1 (&prefix_text2, *start_list, NULL, 1); - if (!elt || elt == (struct cmd_list_element *) -1) + if (elt == NULL || elt == CMD_LIST_AMBIGUOUS) { msg = xstrprintf (_("could not find command prefix '%s'"), prefix_text); xfree (prefix_text); diff --git a/gdb/python/py-cmd.c b/gdb/python/py-cmd.c index 8bc4bf7..45af66b 100644 --- a/gdb/python/py-cmd.c +++ b/gdb/python/py-cmd.c @@ -487,7 +487,7 @@ gdbpy_parse_command_name (const char *name, prefix_text2 = prefix_text; elt = lookup_cmd_1 (&prefix_text2, *start_list, NULL, 1); - if (!elt || elt == (struct cmd_list_element *) -1) + if (elt == NULL || elt == CMD_LIST_AMBIGUOUS) { PyErr_Format (PyExc_RuntimeError, _("Could not find command prefix %s."), prefix_text); |