diff options
| author | Pedro Alves <pedro@palves.net> | 2022-05-06 20:09:04 +0100 |
|---|---|---|
| committer | Pedro Alves <pedro@palves.net> | 2022-05-20 20:40:59 +0100 |
| commit | 1c2cbcf1de2d3fcba119ff4ef01dc1b74923daeb (patch) | |
| tree | 17c6d5596e553c51cbcff66e8af536f6d05a611e /gdb | |
| parent | 06615628294ceb515c045050a39cff4d66a20c1e (diff) | |
| download | fsf-binutils-gdb-1c2cbcf1de2d3fcba119ff4ef01dc1b74923daeb.zip fsf-binutils-gdb-1c2cbcf1de2d3fcba119ff4ef01dc1b74923daeb.tar.gz fsf-binutils-gdb-1c2cbcf1de2d3fcba119ff4ef01dc1b74923daeb.tar.bz2 | |
Make structs breakpoint/base_breakpoint/catchpoint be abstract
You should never instanciate these types directly.
Change-Id: I8086c74c415eadbd44924bb0ef20f34b5b97ee6f
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/breakpoint.c | 15 | ||||
| -rw-r--r-- | gdb/breakpoint.h | 6 |
2 files changed, 20 insertions, 1 deletions
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 385c92a..8f67945 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -252,6 +252,21 @@ static const struct breakpoint_ops tracepoint_probe_breakpoint_ops = create_breakpoints_sal, }; +/* Implementation of abstract dtors. These must exist to satisfy the + linker. */ + +breakpoint::~breakpoint () +{ +} + +base_breakpoint::~base_breakpoint () +{ +} + +catchpoint::~catchpoint () +{ +} + /* The structure to be used in regular breakpoints. */ struct ordinary_breakpoint : public base_breakpoint { diff --git a/gdb/breakpoint.h b/gdb/breakpoint.h index fb8651c..b7e3b4d 100644 --- a/gdb/breakpoint.h +++ b/gdb/breakpoint.h @@ -631,7 +631,7 @@ struct breakpoint DISABLE_COPY_AND_ASSIGN (breakpoint); - virtual ~breakpoint () = default; + virtual ~breakpoint () = 0; /* Allocate a location for this breakpoint. */ virtual struct bp_location *allocate_location (); @@ -862,6 +862,8 @@ struct base_breakpoint : public breakpoint { using breakpoint::breakpoint; + ~base_breakpoint () override = 0; + void re_set () override; int insert_location (struct bp_location *) override; int remove_location (struct bp_location *, @@ -1023,6 +1025,8 @@ struct catchpoint : public base_breakpoint COND_STRING is not NULL, then store it in the breakpoint. */ catchpoint (struct gdbarch *gdbarch, bool temp, const char *cond_string); + ~catchpoint () override = 0; + void re_set () override { /* For catchpoints, the default is to do nothing. */ |