aboutsummaryrefslogtreecommitdiff
path: root/gdb/windows-tdep.c
diff options
context:
space:
mode:
authorSimon Marchi <simon.marchi@ericsson.com>2017-09-16 14:19:31 +0200
committerSimon Marchi <simon.marchi@ericsson.com>2017-09-16 14:19:31 +0200
commit5e1875543df7413d3cbc3831390445e347064b75 (patch)
tree215e09584279387448ae183671588f0bac07a1f6 /gdb/windows-tdep.c
parentc3d7b541fa920e6ecb0f06ffe1e0e3f070fa295d (diff)
downloadfsf-binutils-gdb-5e1875543df7413d3cbc3831390445e347064b75.zip
fsf-binutils-gdb-5e1875543df7413d3cbc3831390445e347064b75.tar.gz
fsf-binutils-gdb-5e1875543df7413d3cbc3831390445e347064b75.tar.bz2
Make xml_escape_text return an std::string
This is a simple replacement, it allows removing some manual free'ing in the callers. gdb/ChangeLog: * common/buffer.c (buffer_xml_printf): Adjust. * common/xml-utils.c (xml_escape_text): Change return type to std::string, update code accordingly. * common/xml-utils.h (xml_escape_text): Change return type to std::string. * rs6000-aix-tdep.c (rs6000_aix_shared_library_to_xml): Adjust. * windows-tdep.c (windows_xfer_shared_library): Adjust. * unittests/xml-utils-selftests.c (test_xml_escape_text): Adjust. gdb/gdbserver/ChangeLog: * linux-low.c (linux_qxfer_libraries_svr4): Adjust to change of return type of xml_escape_text. * server.c (emit_dll_description): Likewise.
Diffstat (limited to 'gdb/windows-tdep.c')
-rw-r--r--gdb/windows-tdep.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/gdb/windows-tdep.c b/gdb/windows-tdep.c
index 886c4ec..197d779 100644
--- a/gdb/windows-tdep.c
+++ b/gdb/windows-tdep.c
@@ -371,13 +371,11 @@ void
windows_xfer_shared_library (const char* so_name, CORE_ADDR load_addr,
struct gdbarch *gdbarch, struct obstack *obstack)
{
- char *p;
CORE_ADDR text_offset;
obstack_grow_str (obstack, "<library name=\"");
- p = xml_escape_text (so_name);
- obstack_grow_str (obstack, p);
- xfree (p);
+ std::string p = xml_escape_text (so_name);
+ obstack_grow_str (obstack, p.c_str ());
obstack_grow_str (obstack, "\"><segment address=\"");
gdb_bfd_ref_ptr dll (gdb_bfd_open (so_name, gnutarget, -1));
/* The following calls are OK even if dll is NULL.