diff options
author | Tom de Vries <tdevries@suse.de> | 2023-06-07 14:57:40 +0200 |
---|---|---|
committer | Tom de Vries <tdevries@suse.de> | 2023-06-07 14:57:40 +0200 |
commit | a6bc87757c85035a7cbb44da0706084043af68d1 (patch) | |
tree | 88b76c7c0654ec779192af5a9d4e4f0e43866b50 /gdb/valprint.h | |
parent | 22f2cf64f178fa3c85508d08fe10dd4e98af4751 (diff) | |
download | fsf-binutils-gdb-a6bc87757c85035a7cbb44da0706084043af68d1.zip fsf-binutils-gdb-a6bc87757c85035a7cbb44da0706084043af68d1.tar.gz fsf-binutils-gdb-a6bc87757c85035a7cbb44da0706084043af68d1.tar.bz2 |
[gdb/cli] Handle pending ^C after rl_callback_read_char for readline 7
In commit faf01aee1d0 ("[gdb] Handle pending ^C after rl_callback_read_char")
we handled a problem (described in detail in that commit) for readline >= 8
using public readline functions rl_pending_signal and rl_check_signals.
For readline 7 (note that we require at least readline 7 so there's no need to
worry about readline 6), there was no fix though, because rl_check_signals was
not available.
Fix this by instead using the private readline function _rl_signal_handler.
There is precedent for using private readline variables and functions, but
it's something we want to get rid of (PR build/10723). Nevertheless, I think
we can allow this specific instance because it's not used when building
against readline >= 8.
[ In the meanwhile, a fix was committed in the devel branch of the readline
repo, contained in commit 8d0c439 ("rollup of changes since readline-8.2"),
first proposed here (
https://lists.gnu.org/archive/html/bug-readline/2022-10/msg00008.html ). ]
Tested on x86_64-linux, against system readline 7.0 on openSUSE Leap 15.4.
PR cli/27813
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=27813
Diffstat (limited to 'gdb/valprint.h')
0 files changed, 0 insertions, 0 deletions