diff options
| author | Andrew Cagney <cagney@redhat.com> | 2003-03-25 22:56:41 +0000 |
|---|---|---|
| committer | Andrew Cagney <cagney@redhat.com> | 2003-03-25 22:56:41 +0000 |
| commit | f933a9c5851c1f824cdebb439a101e6f0ea1688e (patch) | |
| tree | 057bd8f42fc183e0f072cd92dfb5ae25a7f50180 /gdb/valops.c | |
| parent | e16bb312f5bec8b2305f400898523122a6fdad63 (diff) | |
| download | fsf-binutils-gdb-f933a9c5851c1f824cdebb439a101e6f0ea1688e.zip fsf-binutils-gdb-f933a9c5851c1f824cdebb439a101e6f0ea1688e.tar.gz fsf-binutils-gdb-f933a9c5851c1f824cdebb439a101e6f0ea1688e.tar.bz2 | |
2003-03-25 Andrew Cagney <cagney@redhat.com>
* gdbarch.sh (DEPRECATED_EXTRA_STACK_ALIGNMENT_NEEDED): Replace
EXTRA_STACK_ALIGNMENT_NEEDED. Default to 0 not 1.
* gdbarch.h, gdbarch.c: Re-generate.
* config/sparc/tm-sparc.h
(DEPRECATED_EXTRA_STACK_ALIGNMENT_NEEDED): Define.
* sparc-tdep.c (sparc_gdbarch_init): Set
deprecated_extra_stack_alignment_needed.
* config/pa/tm-hppa.h (EXTRA_STACK_ALIGNMENT_NEEDED): Delete.
* xstormy16-tdep.c (xstormy16_gdbarch_init): Do not clear
extra_stack_alignment_needed.
* v850-tdep.c (v850_gdbarch_init): Ditto.
* hppa-tdep.c (hppa_gdbarch_init): Ditto.
* h8300-tdep.c (h8300_gdbarch_init): Ditto.
* d10v-tdep.c (d10v_gdbarch_init): Ditto.
* cris-tdep.c (cris_gdbarch_init): Ditto.
* m68k-tdep.c (m68k_gdbarch_init): Ditto.
* m68hc11-tdep.c (m68hc11_gdbarch_init): Ditto.
Diffstat (limited to 'gdb/valops.c')
| -rw-r--r-- | gdb/valops.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/gdb/valops.c b/gdb/valops.c index f6c83ac..ff24a9f 100644 --- a/gdb/valops.c +++ b/gdb/valops.c @@ -1599,7 +1599,10 @@ You must use a pointer to function type variable. Command ignored.", arg_name); on other architectures. This is because all the alignment is taken care of in the above code (ifdef REG_STRUCT_HAS_ADDR) and in hppa_push_arguments */ - if (EXTRA_STACK_ALIGNMENT_NEEDED) + /* NOTE: cagney/2003-03-24: The below code is very broken. Given an + odd sized parameter the below will mis-align the stack. As was + suggested back in '96, better to let PUSH_ARGUMENTS handle it. */ + if (DEPRECATED_EXTRA_STACK_ALIGNMENT_NEEDED) { /* MVS 11/22/96: I think at least some of this stack_align code is really broken. Better to let PUSH_ARGUMENTS adjust the |