diff options
| author | Yao Qi <yao.qi@linaro.org> | 2017-03-22 12:35:31 +0000 |
|---|---|---|
| committer | Yao Qi <yao.qi@linaro.org> | 2017-03-22 12:35:31 +0000 |
| commit | ffdbe8642e74527795b695988a176f0920d58f96 (patch) | |
| tree | 3bda2f4d3c3d0e7adc3e6ce77ebfb5af27165059 /gdb/ui-out.c | |
| parent | 9d736fbf01d20bc03804fa0cb49d99fdf6628fab (diff) | |
| download | fsf-binutils-gdb-ffdbe8642e74527795b695988a176f0920d58f96.zip fsf-binutils-gdb-ffdbe8642e74527795b695988a176f0920d58f96.tar.gz fsf-binutils-gdb-ffdbe8642e74527795b695988a176f0920d58f96.tar.bz2 | |
Wrap locally used classes in anonymous namespace
Both aarch64-tdep.c and arm-tdep.c defines a class instruction_reader, which
violates ODR, but linker doesn't an emit error. I fix this issue by wrapping
them by anonymous namespace, but I think it is better to apply this for all
locally used classes.
If it is a good idea to put locally used class into anonymous namespace, we
should document this rule into GDB coding convention, or even GCC coding
convention. Note that anonymous namespace has been used in GCC but GCC
coding convention doesn't mention the it.
gdb:
2017-03-22 Yao Qi <yao.qi@linaro.org>
* aarch64-tdep.c: Wrap locally used classes in anonymous
namespace.
* arm-tdep.c: Likewise.
* linespec.c: Likewise.
* ui-out.c: Likewise.
Diffstat (limited to 'gdb/ui-out.c')
| -rw-r--r-- | gdb/ui-out.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/gdb/ui-out.c b/gdb/ui-out.c index 42cffbe..9c27742 100644 --- a/gdb/ui-out.c +++ b/gdb/ui-out.c @@ -30,6 +30,8 @@ #include <string> #include <memory> +namespace { + /* A header of a ui_out_table. */ class ui_out_hdr @@ -91,6 +93,8 @@ class ui_out_hdr std::string m_header; }; +} // namespace + /* A level of nesting (either a list or a tuple) in a ui_out output. */ class ui_out_level |