diff options
| author | Tom Tromey <tom@tromey.com> | 2019-11-12 17:26:50 -0700 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2019-12-20 09:15:52 -0700 |
| commit | 61c33f105c71d27386e5b3cc6e1c5f71efe7ed01 (patch) | |
| tree | 3d61884a4c61df3cb404f931731d617fc4fe6060 /gdb/tui/tui-disasm.c | |
| parent | 469b073133fa35b54ab4f1bc3dee42ccede84689 (diff) | |
| download | fsf-binutils-gdb-61c33f105c71d27386e5b3cc6e1c5f71efe7ed01.zip fsf-binutils-gdb-61c33f105c71d27386e5b3cc6e1c5f71efe7ed01.tar.gz fsf-binutils-gdb-61c33f105c71d27386e5b3cc6e1c5f71efe7ed01.tar.bz2 | |
Change tui_source_window_base::set_contents to return bool
This changes tui_source_window_base::set_contents to return bool,
rather than tui_status. It also changes one implementation of
set_contents to use early returns rather than a variable, which IMO
makes it easier to follow.
gdb/ChangeLog
2019-12-20 Tom Tromey <tom@tromey.com>
* tui/tui-winsource.h (struct tui_source_window_base)
<set_contents>: Return bool.
* tui/tui-winsource.c
(tui_source_window_base::update_source_window_as_is): Update.
* tui/tui-source.h (struct tui_source_window) <set_contents>:
Return bool.
* tui/tui-source.c (tui_source_window::set_contents): Return
bool. Simplify.
* tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
Return bool.
* tui/tui-disasm.c (tui_disasm_window::set_contents): Return
bool.
Change-Id: I8c5212400cd7aadf35760c22d5344cd3b9435674
Diffstat (limited to 'gdb/tui/tui-disasm.c')
| -rw-r--r-- | gdb/tui/tui-disasm.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/gdb/tui/tui-disasm.c b/gdb/tui/tui-disasm.c index c49369a..080253c 100644 --- a/gdb/tui/tui-disasm.c +++ b/gdb/tui/tui-disasm.c @@ -198,7 +198,7 @@ tui_find_disassembly_address (struct gdbarch *gdbarch, CORE_ADDR pc, int from) } /* Function to set the disassembly window's content. */ -enum tui_status +bool tui_disasm_window::set_contents (struct gdbarch *arch, struct symtab *s, struct tui_line_or_address line_or_addr) @@ -214,7 +214,7 @@ tui_disasm_window::set_contents (struct gdbarch *arch, gdb_assert (line_or_addr.loa == LOA_ADDRESS); CORE_ADDR pc = line_or_addr.u.addr; if (pc == 0) - return TUI_FAILURE; + return false; gdbarch = arch; start_line_or_addr.loa = LOA_ADDRESS; @@ -251,7 +251,7 @@ tui_disasm_window::set_contents (struct gdbarch *arch, src->line_or_addr.u.addr = asm_lines[i].addr; src->is_exec_point = asm_lines[i].addr == cur_pc; } - return TUI_SUCCESS; + return true; } |