diff options
| author | Tom Tromey <tom@tromey.com> | 2016-06-06 14:18:23 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2016-07-14 10:35:40 -0600 |
| commit | ac29888840f025448225e600d4cf99e126386878 (patch) | |
| tree | 8c92ab02d4267d9a81cff5b770f24fb6f222b231 /gdb/tracefile.c | |
| parent | 764c99c18adcdf658b390f25940aed7713a6a769 (diff) | |
| download | fsf-binutils-gdb-ac29888840f025448225e600d4cf99e126386878.zip fsf-binutils-gdb-ac29888840f025448225e600d4cf99e126386878.tar.gz fsf-binutils-gdb-ac29888840f025448225e600d4cf99e126386878.tar.bz2 | |
Remove some variables but call functions for side effects
This patch consolidates the (possibly-questionable) spots where we
remove a declaration but continue to call some function for side
effects. In a couple of cases it wasn't entirely clear to me that
this mattered; and in some other cases it might be more aesthetically
pleasing to use ATTRIBUTE_UNUSED. So, I broke this out into a
separate patch for simpler review.
2016-07-14 Tom Tromey <tom@tromey.com>
* arch-utils.c (default_skip_permanent_breakpoint): Remove
"bp_insn".
* disasm.c (do_assembly_only): Remove "num_displayed".
* dwarf2read.c (read_abbrev_offset): Remove "length".
(dwarf_decode_macro_bytes) <DW_MACINFO_vendor_ext>: Remove
"constant".
* m32c-tdep.c (make_regs): Remove "r2hl", "r3hl", and "intbhl".
* microblaze-tdep.c (microblaze_frame_cache): Remove "func".
* tracefile.c (trace_save): Remove "status".
Diffstat (limited to 'gdb/tracefile.c')
| -rw-r--r-- | gdb/tracefile.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/gdb/tracefile.c b/gdb/tracefile.c index c32bcf4..56fb0d2 100644 --- a/gdb/tracefile.c +++ b/gdb/tracefile.c @@ -57,7 +57,6 @@ trace_save (const char *filename, struct trace_file_writer *writer, int target_does_save) { struct trace_status *ts = current_trace_status (); - int status; struct uploaded_tp *uploaded_tps = NULL, *utp; struct uploaded_tsv *uploaded_tsvs = NULL, *utsv; @@ -77,8 +76,10 @@ trace_save (const char *filename, struct trace_file_writer *writer, } /* Get the trace status first before opening the file, so if the - target is losing, we can get out without touching files. */ - status = target_get_trace_status (ts); + target is losing, we can get out without touching files. Since + we're just calling this for side effects, we ignore the + result. */ + target_get_trace_status (ts); writer->ops->start (writer, filename); |