diff options
author | Tom de Vries <tdevries@suse.de> | 2022-08-07 08:31:37 +0200 |
---|---|---|
committer | Tom de Vries <tdevries@suse.de> | 2022-08-07 08:31:37 +0200 |
commit | c7cd10637c40a72564bc813f3f16a4ba4b13d21b (patch) | |
tree | c610c3779745c2bd03cf2384eb2e8984c2a8ba34 /gdb/testsuite | |
parent | f4cbdf0b6857069d42477e06f0077f4c03bb4c82 (diff) | |
download | fsf-binutils-gdb-c7cd10637c40a72564bc813f3f16a4ba4b13d21b.zip fsf-binutils-gdb-c7cd10637c40a72564bc813f3f16a4ba4b13d21b.tar.gz fsf-binutils-gdb-c7cd10637c40a72564bc813f3f16a4ba4b13d21b.tar.bz2 |
[gdb/symtab] Fix assert in read_addrmap_from_aranges
When loading the debug-names-duplicate-cu executable included in this
test-case, we run into:
...
(gdb) file debug-names-duplicate-cu^M
Reading symbols from debug-names-duplicate-cu...^M
src/gdb/dwarf2/read.c:2353: internal-error: read_addrmap_from_aranges: \
Assertion `insertpair.second' failed.^M
...
This assert was added in recent commit 75337cbc147 ("[gdb/symtab] Fix
.debug_aranges duplicate offset warning").
The assert triggers because the CU table in the .debug_names section contains
a duplicate:
...
Version 5
Augmentation string: 47 44 42 00 ("GDB")
CU table:
[ 0] 0x0
[ 1] 0x0
...
Fix this by rejecting the .debug_names index:
...
(gdb) file debug-names-duplicate-cu^M
Reading symbols from debug-names-duplicate-cu...^M
warning: Section .debug_names has duplicate entry in CU table, \
ignoring .debug_names.^M
...
Likewise for the case where the CU table is not sorted by increasing offset.
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29436
Diffstat (limited to 'gdb/testsuite')
-rw-r--r-- | gdb/testsuite/gdb.dwarf2/debug-names-duplicate-cu.exp | 78 | ||||
-rw-r--r-- | gdb/testsuite/gdb.dwarf2/debug-names-non-ascending-cu.exp | 83 |
2 files changed, 161 insertions, 0 deletions
diff --git a/gdb/testsuite/gdb.dwarf2/debug-names-duplicate-cu.exp b/gdb/testsuite/gdb.dwarf2/debug-names-duplicate-cu.exp new file mode 100644 index 0000000..a79a60a --- /dev/null +++ b/gdb/testsuite/gdb.dwarf2/debug-names-duplicate-cu.exp @@ -0,0 +1,78 @@ +# Copyright 2022 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +load_lib dwarf.exp + +# This test can only be run on targets which support DWARF-2 and use gas. +if {![dwarf2_support]} { + return 0 +} + +standard_testfile _start.c debug-names.S + +set func_info_vars \ + [get_func_info _start [list debug additional_flags=-nostartfiles]] + +# Create the DWARF. +set asm_file [standard_output_file $srcfile2] +Dwarf::assemble { + filename $asm_file + add_dummy_cus 0 +} { + global func_info_vars + foreach var $func_info_vars { + global $var + } + + cu { label cu_label } { + compile_unit {{language @DW_LANG_C}} { + subprogram { + {DW_AT_name _start} + {DW_AT_low_pc $_start_start DW_FORM_addr} + {DW_AT_high_pc $_start_end DW_FORM_addr} + } + base_type { + {name int} + {byte_size 4 sdata} + {encoding @DW_ATE_signed} + } + } + } + + debug_names {} { + cu cu_label + cu cu_label + name _start subprogram cu_label 0xEDDB6232 + name int base_type cu_label 0xB888030 + } +} + +if [prepare_for_testing "failed to prepare" $testfile "${asm_file} ${srcfile}" \ + [list additional_flags=-nostartfiles]] { + return -1 +} + +# Check for warning. +set re \ + [list \ + "warning:" \ + "Section .debug_names has duplicate entry in CU table," \ + "ignoring .debug_names."] +set re [join $re] +gdb_assert {[regexp $re $gdb_file_cmd_msg]} "warning" + +# Verify that .debug_names section is ignored. +set index [have_index $binfile] +gdb_assert { [string equal $index ""] } ".debug_names not used" diff --git a/gdb/testsuite/gdb.dwarf2/debug-names-non-ascending-cu.exp b/gdb/testsuite/gdb.dwarf2/debug-names-non-ascending-cu.exp new file mode 100644 index 0000000..53523ee --- /dev/null +++ b/gdb/testsuite/gdb.dwarf2/debug-names-non-ascending-cu.exp @@ -0,0 +1,83 @@ +# Copyright 2022 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +load_lib dwarf.exp + +# This test can only be run on targets which support DWARF-2 and use gas. +if {![dwarf2_support]} { + return 0 +} + +standard_testfile _start.c debug-names.S + +set func_info_vars \ + [get_func_info _start [list debug additional_flags=-nostartfiles]] + +# Create the DWARF. +set asm_file [standard_output_file $srcfile2] +Dwarf::assemble { + filename $asm_file + add_dummy_cus 0 +} { + global func_info_vars + foreach var $func_info_vars { + global $var + } + + cu { label cu_label } { + compile_unit {{language @DW_LANG_C}} { + subprogram { + {DW_AT_name _start} + {DW_AT_low_pc $_start_start DW_FORM_addr} + {DW_AT_high_pc $_start_end DW_FORM_addr} + } + } + } + + cu { label cu_label_2 } { + compile_unit {{language @DW_LANG_C}} { + base_type { + {name int} + {byte_size 4 sdata} + {encoding @DW_ATE_signed} + } + } + } + + debug_names {} { + cu cu_label_2 + cu cu_label + name _start subprogram cu_label 0xEDDB6232 + name int base_type cu_label 0xB888030 + } +} + +if [prepare_for_testing "failed to prepare" $testfile "${asm_file} ${srcfile}" \ + [list additional_flags=-nostartfiles]] { + return -1 +} + +# Check for warning. +set re \ + [list \ + "warning:" \ + "Section .debug_names has non-ascending CU table," \ + "ignoring .debug_names."] +set re [join $re] +gdb_assert {[regexp $re $gdb_file_cmd_msg]} "warning" + +# Verify that .debug_names section is ignored. +set index [have_index $binfile] +gdb_assert { [string equal $index ""] } ".debug_names not used" |