diff options
| author | Andrew Burgess <aburgess@redhat.com> | 2022-02-01 10:28:18 +0000 |
|---|---|---|
| committer | Andrew Burgess <aburgess@redhat.com> | 2022-04-03 15:31:47 +0100 |
| commit | b0fcf3e344438a4d115afdfaa7468bf90cc8c880 (patch) | |
| tree | 0fb6d17444f09f11cbc316f10a5e4dbfc7147ffe /gdb/testsuite/gdb.tui/basic.exp | |
| parent | 47b8e12ffd0ecf924836aed55eb63b9e5d9e8ea1 (diff) | |
| download | fsf-binutils-gdb-b0fcf3e344438a4d115afdfaa7468bf90cc8c880.zip fsf-binutils-gdb-b0fcf3e344438a4d115afdfaa7468bf90cc8c880.tar.gz fsf-binutils-gdb-b0fcf3e344438a4d115afdfaa7468bf90cc8c880.tar.bz2 | |
gdb/tui: fairer distribution of excess space during apply
When applying layouts gdb computes the size of each window (or rather,
each sub-layout within a layout) using integer arithmetic. As this
rounds down the results, then, when all sub-layouts are sized, there
is the possibility that we have some space left over.
Currently, this space is just assigned to an arbitrary sub-layout.
This can result in some unbalanced results. Consider this set of
steps with current master:
(gdb) tui enable
(gdb) layout regs
(gdb) info win
Name Lines Columns Focus
regs 7 80
src 9 80 (has focus)
status 1 80
cmd 8 80
Notice the weird split between the src and regs windows, the original
layout specification has these windows given equal weight. The
problem is that, with rounding, both the regs and src windows are
initially sized to 7, the extra 2 lines are then arbitrarily added to
the src window.
In this commit, rather than add all the extra space to one single
window, I instead hand out the extra space 1 line at a time, looping
over all the sub-layouts. We take care to respect the min/max sizes,
and so, we now get this result:
(gdb) tui enable
(gdb) layout regs
(gdb) info win
Name Lines Columns Focus
regs 8 80
src 8 80 (has focus)
status 1 80
cmd 8 80
This looks more natural to me.
This is obviously a change in behaviour, and so, lots of the existing
tests need to be updated to take this into account. None of the
changes are huge, it's just a line or two (or column for width) moved
between windows.
Diffstat (limited to 'gdb/testsuite/gdb.tui/basic.exp')
| -rw-r--r-- | gdb/testsuite/gdb.tui/basic.exp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/gdb/testsuite/gdb.tui/basic.exp b/gdb/testsuite/gdb.tui/basic.exp index 0e9f2e3..7afb28b 100644 --- a/gdb/testsuite/gdb.tui/basic.exp +++ b/gdb/testsuite/gdb.tui/basic.exp @@ -104,5 +104,5 @@ Term::command "layout split" Term::check_contents "split layout contents" \ "$main_line *$main_re.*$hex <main>" -Term::check_box "source box in split layout" 0 0 80 7 -Term::check_box "asm box in split layout" 0 6 80 9 +Term::check_box "source box in split layout" 0 0 80 8 +Term::check_box "asm box in split layout" 0 7 80 8 |