diff options
| author | Tom Tromey <tom@tromey.com> | 2019-07-12 18:18:10 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2019-08-16 14:17:36 -0600 |
| commit | 398fdd6086a290748afcce0efabaebb4e363278c (patch) | |
| tree | a661b12700f45fc6e8bf573ecffc91c10740f454 /gdb/testsuite/gdb.tui/basic.exp | |
| parent | e699d33164a59dcfe7ad4a5154e5c6c811c1f958 (diff) | |
| download | fsf-binutils-gdb-398fdd6086a290748afcce0efabaebb4e363278c.zip fsf-binutils-gdb-398fdd6086a290748afcce0efabaebb4e363278c.tar.gz fsf-binutils-gdb-398fdd6086a290748afcce0efabaebb4e363278c.tar.bz2 | |
Remove the TUI execution info window
The TUI execution info window is unusual in that it is always linked
to a source or disassembly window. Even updates of its content are
handled by the source window, so it really has no life of its own.
This patch removes this window entirely and puts its functionality
directly into the source window. This simplifies the code somewhat.
This is a user-visible change, because now the box around the source
(or disassembly) window encloses the execution info as well. I
consider this an improvement as well, though.
Note that this patch caused ncurses to start emitting the "CSI Z"
sequence, so I've added this to the test suite terminal
implementation.
gdb/ChangeLog
2019-08-16 Tom Tromey <tom@tromey.com>
* tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
* tui/tui-winsource.h (struct tui_exec_info_window): Remove.
(struct tui_source_window_base) <make_visible, refresh_window,
resize>: Remove methods.
<execution_info>: Remove field.
* tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
(tui_show_source_line, tui_source_window_base)
(~tui_source_window_base): Update.
(tui_source_window_base::resize)
(tui_source_window_base::make_visible)
(tui_source_window_base::refresh_window): Remove.
(tui_source_window_base::update_exec_info): Update.
* tui/tui-source.c (tui_source_window::set_contents): Update.
* tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
gdb/testsuite/ChangeLog
2019-08-16 Tom Tromey <tom@tromey.com>
* lib/tuiterm.exp (_csi_Z): New proc.
* gdb.tui/basic.exp: Update window positions.
* gdb.tui/empty.exp: Update window positions.
Diffstat (limited to 'gdb/testsuite/gdb.tui/basic.exp')
| -rw-r--r-- | gdb/testsuite/gdb.tui/basic.exp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/gdb/testsuite/gdb.tui/basic.exp b/gdb/testsuite/gdb.tui/basic.exp index a005400..f60011c 100644 --- a/gdb/testsuite/gdb.tui/basic.exp +++ b/gdb/testsuite/gdb.tui/basic.exp @@ -38,12 +38,12 @@ Term::check_contents "list main" "21 *return 0" # This check fails because the file name in the title overwrites the # box. setup_xfail *-*-* -Term::check_box "source box" 3 0 77 15 +Term::check_box "source box" 0 0 80 15 Term::command "layout asm" Term::check_contents "asm window shows main" "$hex <main>" -Term::check_box "asm box" 3 0 77 15 +Term::check_box "asm box" 0 0 80 15 Term::command "layout split" Term::check_contents "split layout contents" "21 *return 0.*$hex <main>" @@ -51,5 +51,5 @@ Term::check_contents "split layout contents" "21 *return 0.*$hex <main>" # This check fails because the file name in the title overwrites the # box. setup_xfail *-*-* -Term::check_box "source box in split layout" 3 0 77 8 -Term::check_box "asm box in split layout" 3 7 77 8 +Term::check_box "source box in split layout" 0 0 80 8 +Term::check_box "asm box in split layout" 0 7 80 8 |