diff options
author | Tom Tromey <tom@tromey.com> | 2018-05-16 22:54:44 -0600 |
---|---|---|
committer | Tom Tromey <tom@tromey.com> | 2018-05-23 09:17:01 -0600 |
commit | b98664d3862579c5a0d23901b1e2fc1f595f39ff (patch) | |
tree | 7659c15ce611083c429716e8e71bd744f3b6163a /gdb/testsuite/gdb.gdb | |
parent | 4e9668d0d1ddad73af7c20a92a00704fbea2a8d9 (diff) | |
download | fsf-binutils-gdb-b98664d3862579c5a0d23901b1e2fc1f595f39ff.zip fsf-binutils-gdb-b98664d3862579c5a0d23901b1e2fc1f595f39ff.tar.gz fsf-binutils-gdb-b98664d3862579c5a0d23901b1e2fc1f595f39ff.tar.bz2 |
Remove symfile_complaints
The complaint system seems to allow for multiple different complaint
topics. However, in practice only symfile_complaints has ever been
defined. Seeing that complaints.c dates to 1992, and that no new
complaints have been added in the intervening years, I think it is
reasonable to admit that complaints are specifically related to
debuginfo reading.
This patch removes symfile_complaints and updates all the callers.
Some of these spots should perhaps be calls to warning instead, but I
did not make that change.
gdb/ChangeLog
2018-05-23 Tom Tromey <tom@tromey.com>
* complaints.c (symfile_complaints): Remove.
(complaint_internal): Remove "complaints" parameter.
(clear_complaints, vcomplaint): Remove "c" parameter.
(get_complaints): Remove.
* dwarf2read.c (dwarf2_statement_list_fits_in_line_number_section_complaint)
(dwarf2_debug_line_missing_file_complaint)
(dwarf2_debug_line_missing_end_sequence_complaint)
(dwarf2_complex_location_expr_complaint)
(dwarf2_const_value_length_mismatch_complaint)
(dwarf2_section_buffer_overflow_complaint)
(dwarf2_macro_malformed_definition_complaint)
(dwarf2_invalid_attrib_class_complaint)
(create_addrmap_from_index, dw2_symtab_iter_next)
(dw2_expand_marked_cus)
(dw2_debug_names_iterator::find_vec_in_debug_names)
(dw2_debug_names_iterator::next, dw2_debug_names_iterator::next)
(create_debug_type_hash_table, init_cutu_and_read_dies)
(partial_die_parent_scope, add_partial_enumeration)
(skip_one_die, fixup_go_packaging, quirk_rust_enum, process_die)
(dwarf2_compute_name, dwarf2_physname, read_namespace_alias)
(read_import_statement, read_file_scope, create_dwo_cu_reader)
(create_cus_hash_table, create_dwp_hash_table)
(inherit_abstract_dies, read_func_scope, read_call_site_scope)
(dwarf2_rnglists_process, dwarf2_ranges_process)
(dwarf2_add_type_defn, dwarf2_attach_fields_to_type)
(dwarf2_add_member_fn, get_alignment, maybe_set_alignment)
(handle_struct_member_die, process_structure_scope)
(read_array_type, read_common_block, read_module_type)
(read_tag_pointer_type, read_typedef, read_base_type)
(read_subrange_type, load_partial_dies, partial_die_info::read)
(partial_die_info::read, partial_die_info::read)
(partial_die_info::read, read_checked_initial_length_and_offset)
(dwarf2_string_attr, read_formatted_entries)
(dwarf_decode_line_header)
(lnp_state_machine::check_line_address, dwarf_decode_lines_1)
(new_symbol, dwarf2_const_value_attr, lookup_die_type)
(read_type_die_1, determine_prefix, dwarf2_get_ref_die_offset)
(dwarf2_get_attr_constant_value, dwarf2_fetch_constant_bytes)
(get_signatured_type, get_DW_AT_signature_type)
(decode_locdesc, file_file_name, consume_improper_spaces)
(skip_form_bytes, skip_unknown_opcode, dwarf_parse_macro_header)
(dwarf_decode_macro_bytes, dwarf_decode_macros)
(dwarf2_symbol_mark_computed, set_die_type)
(read_attribute_value): Update.
* stap-probe.c (handle_stap_probe, get_stap_base_address):
Update.
* dbxread.c (unknown_symtype_complaint)
(lbrac_mismatch_complaint, repeated_header_complaint)
(set_namestring, function_outside_compilation_unit_complaint)
(read_dbx_symtab, process_one_symbol): Update.
* gdbtypes.c (stub_noname_complaint): Update.
* windows-nat.c (handle_unload_dll): Update.
* coffread.c (coff_symtab_read, enter_linenos, decode_type)
(decode_base_type): Update.
* xcoffread.c (bf_notfound_complaint, ef_complaint)
(eb_complaint, record_include_begin, record_include_end)
(enter_line_range, xcoff_next_symbol_text, read_xcoff_symtab)
(process_xcoff_symbol, read_symbol)
(function_outside_compilation_unit_complaint)
(scan_xcoff_symtab): Update.
* machoread.c (macho_symtab_read, macho_add_oso_symfile): Update.
* buildsym.c (finish_block_internal, make_blockvector)
(end_symtab_get_static_block, augment_type_symtab): Update.
* dtrace-probe.c (dtrace_process_dof)
(dtrace_static_probe_ops::get_probes): Update.
* complaints.h (struct complaint): Don't declare.
(symfile_complaints): Remove.
(complaint_internal): Remove "complaints" parameter.
(complaint): Likewise.
(clear_complaints): Likewise.
* symfile.c (syms_from_objfile_1, finish_new_objfile)
(reread_symbols): Update.
* dwarf2-frame.c (dwarf2_restore_rule, execute_cfa_program)
(dwarf2_frame_cache, decode_frame_entry): Update.
* dwarf2loc.c (dwarf_reg_to_regnum): Update.
* objc-lang.c (lookup_objc_class, lookup_child_selector)
(info_selectors_command): Update.
* macrotab.c (macro_include, check_for_redefinition)
(macro_undef): Update.
* objfiles.c (filter_overlapping_sections): Update.
* stabsread.c (invalid_cpp_abbrev_complaint)
(reg_value_complaint, stabs_general_complaint, dbx_lookup_type)
(define_symbol, error_type, read_type, rs6000_builtin_type)
(stabs_method_name_from_physname, read_member_functions)
(read_cpp_abbrev, read_baseclasses, read_tilde_fields)
(attach_fields_to_type, complain_about_struct_wipeout)
(read_range_type, read_args, common_block_start)
(common_block_end, cleanup_undefined_types_1, scan_file_globals):
Update.
* mdebugread.c (index_complaint, unknown_ext_complaint)
(basic_type_complaint, bad_tag_guess_complaint)
(bad_rfd_entry_complaint, unexpected_type_code_complaint)
(reg_value_complaint, parse_symbol, parse_type, upgrade_type)
(parse_procedure, parse_lines)
(function_outside_compilation_unit_complaint)
(parse_partial_symbols, psymtab_to_symtab_1, cross_ref)
(bad_tag_guess_complaint, reg_value_complaint): Update.
* cp-support.c (demangled_name_complaint): Update.
* macroscope.c (sal_macro_scope): Update.
* dwarf-index-write.c (class debug_names): Update.
gdb/testsuite/ChangeLog
2018-05-23 Tom Tromey <tom@tromey.com>
* gdb.gdb/complaints.exp (test_initial_complaints): Don't mention
symfile_complaints.
(test_short_complaints): Likewise.
(test_empty_complaints): Likewise.
(test_initial_complaints): Update.
Diffstat (limited to 'gdb/testsuite/gdb.gdb')
-rw-r--r-- | gdb/testsuite/gdb.gdb/complaints.exp | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/gdb/testsuite/gdb.gdb/complaints.exp b/gdb/testsuite/gdb.gdb/complaints.exp index 774ff89..886b435 100644 --- a/gdb/testsuite/gdb.gdb/complaints.exp +++ b/gdb/testsuite/gdb.gdb/complaints.exp @@ -59,27 +59,27 @@ proc test_initial_complaints { } { # Prime the system gdb_test_stdio \ - "call complaint_internal (&symfile_complaints, \"Register a complaint\")" \ + "call complaint_internal (\"Register a complaint\")" \ "During symbol reading, Register a complaint." # Check that the complaint was inserted and where - gdb_test "print symfile_complaints->root->fmt" \ + gdb_test "print symfile_complaint_book.root->fmt" \ ".\[0-9\]+ =.*\"Register a complaint\"" # Re-issue the first message #1 gdb_test_stdio \ - "call complaint_internal (&symfile_complaints, symfile_complaints->root->fmt)" \ + "call complaint_internal (symfile_complaint_book.root->fmt)" \ "During symbol reading, Register a complaint." # Check that there is only one thing in the list. How the boolean # result is output depends on whether GDB is built as a C or C++ # program. - gdb_test "print symfile_complaints->root->next == &complaint_sentinel" \ + gdb_test "print symfile_complaint_book.root->next == &complaint_sentinel" \ ".\[0-9\]+ = \(1|true\)" "list has one entry" # Add a second complaint, expect it gdb_test_stdio \ - "call complaint_internal (&symfile_complaints, \"Testing! Testing! Testing!\")" \ + "call complaint_internal (\"Testing! Testing! Testing!\")" \ "During symbol reading, Testing. Testing. Testing.." return 0 @@ -88,17 +88,17 @@ proc test_initial_complaints { } { # For short complaints, all are the same proc test_short_complaints { } { - gdb_test_exact "call clear_complaints (&symfile_complaints, 1)" "" "short start" + gdb_test_exact "call clear_complaints (1)" "" "short start" # Prime the system test_complaint \ - "call complaint_internal (&symfile_complaints, \"short line 1\")" \ + "call complaint_internal (\"short line 1\")" \ "short line 1..." \ "short line 1" # Add a second complaint, expect it test_complaint \ - "call complaint_internal (&symfile_complaints, \"short line 2\")" \ + "call complaint_internal (\"short line 2\")" \ "short line 2..." \ "short line 2" @@ -131,9 +131,9 @@ proc test_empty_complaint { cmd msg } { proc test_empty_complaints { } { - test_empty_complaint "call clear_complaints(&symfile_complaints,0)" \ + test_empty_complaint "call clear_complaints(0)" \ "empty non-verbose clear" - test_empty_complaint "call clear_complaints(&symfile_complaints,1)" \ + test_empty_complaint "call clear_complaints(1)" \ "empty verbose clear" return 0 |