diff options
author | Simon Marchi <simon.marchi@polymtl.ca> | 2021-09-30 11:52:21 -0400 |
---|---|---|
committer | Simon Marchi <simon.marchi@polymtl.ca> | 2021-09-30 15:27:39 -0400 |
commit | 4dfef5be6812dd7abfbc8f18e9c0384f2522b511 (patch) | |
tree | 90aa986d915c17f2320655298e2799d3a2cd1841 /gdb/testsuite/gdb.base/break.exp | |
parent | 2fed9db40b1179f62c6fb0f2cacfb0db6b50af46 (diff) | |
download | fsf-binutils-gdb-4dfef5be6812dd7abfbc8f18e9c0384f2522b511.zip fsf-binutils-gdb-4dfef5be6812dd7abfbc8f18e9c0384f2522b511.tar.gz fsf-binutils-gdb-4dfef5be6812dd7abfbc8f18e9c0384f2522b511.tar.bz2 |
gdb/testsuite: make runto_main not pass no-message to runto
As follow-up to this discussion:
https://sourceware.org/pipermail/gdb-patches/2020-August/171385.html
... make runto_main not pass no-message to runto. This means that if we
fail to run to main, for some reason, we'll emit a FAIL. This is the
behavior we want the majority of (if not all) the time.
Without this, we rely on tests logging a failure if runto_main fails,
otherwise. They do so in a very inconsisteny mannet, sometimes using
"fail", "unsupported" or "untested". The messages also vary widly.
This patch removes all these messages as well.
Also, remove a few "fail" where we call runto (and not runto_main). by
default (without an explicit no-message argument), runto prints a
failure already. In two places, gdb.multi/multi-re-run.exp and
gdb.python/py-pp-registration.exp, remove "message" passed to runto.
This removes a few PASSes that we don't care about (but FAILs will still
be printed if we fail to run to where we want to). This aligns their
behavior with the rest of the testsuite.
Change-Id: Ib763c98c5f4fb6898886b635210d7c34bd4b9023
Diffstat (limited to 'gdb/testsuite/gdb.base/break.exp')
-rw-r--r-- | gdb/testsuite/gdb.base/break.exp | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/gdb/testsuite/gdb.base/break.exp b/gdb/testsuite/gdb.base/break.exp index c896a48..4885a5b 100644 --- a/gdb/testsuite/gdb.base/break.exp +++ b/gdb/testsuite/gdb.base/break.exp @@ -473,7 +473,9 @@ gdb_test "info break" "Num Type.*Disp Enb Address.*What.*\[\r\n\] # inappropriately. (There are no calls to those system functions # in this test program.) # -if ![runto_main] then { fail "break tests suppressed" } +if ![runto_main] then { + return +} gdb_test "catch fork" "Catchpoint \[0-9\]+ \\(fork\\)" \ "set catch fork, never expected to trigger" @@ -521,7 +523,9 @@ gdb_test "break" \ # Verify that a "silent" breakpoint can be set, and that GDB is indeed # "silent" about its triggering. # -if ![runto_main] then { fail "break tests suppressed" } +if ![runto_main] then { + return +} gdb_test_multiple "break $bp_location1" \ "set to-be-silent break bp_location1" { @@ -637,7 +641,9 @@ gdb_test_multiple "finish" "finish from called function" { # Verify that GDB responds gracefully to a "finish" command with # arguments. # -if ![runto_main] then { fail "break tests suppressed" } +if ![runto_main] then { + return +} send_gdb "finish 123\n" gdb_expect { |