diff options
| author | Tom Tromey <tom@tromey.com> | 2018-03-27 14:31:10 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2018-03-30 13:22:58 -0600 |
| commit | e83e4e24021acb4b095b1e8a45a51c2ea088a1ed (patch) | |
| tree | 4740a6532e556fbb49a7de4234c2913796366212 /gdb/solib-frv.c | |
| parent | 263db9a1f4105b76ddf00829d50430ea0a3bcba6 (diff) | |
| download | fsf-binutils-gdb-e83e4e24021acb4b095b1e8a45a51c2ea088a1ed.zip fsf-binutils-gdb-e83e4e24021acb4b095b1e8a45a51c2ea088a1ed.tar.gz fsf-binutils-gdb-e83e4e24021acb4b095b1e8a45a51c2ea088a1ed.tar.bz2 | |
Change target_read_string to use unique_xmalloc_ptr
This changes the out parameter of target_read_string to be a
unique_xmalloc_ptr. This avoids a cleanup and sets the stage for more
cleanup removals.
This patch also removes a seemingly needless alloca from
print_subexp_standard.
gdb/ChangeLog
2018-03-30 Tom Tromey <tom@tromey.com>
* windows-nat.c (handle_output_debug_string, handle_exception):
Update.
* target.h (target_read_string): Update.
* target.c (target_read_string): Change "string" to
unique_xmalloc_ptr.
* solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
Update.
* solib-frv.c (frv_current_sos): Update.
* solib-dsbt.c (dsbt_current_sos): Update.
* solib-darwin.c (darwin_current_sos): Update.
* linux-thread-db.c (inferior_has_bug): Update.
* expprint.c (print_subexp_standard) <case OP_OBJC_MSGCALL>:
Update. Remove alloca.
* ada-lang.c (ada_main_name): Update.
Diffstat (limited to 'gdb/solib-frv.c')
| -rw-r--r-- | gdb/solib-frv.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/gdb/solib-frv.c b/gdb/solib-frv.c index 7929efd..e772da6 100644 --- a/gdb/solib-frv.c +++ b/gdb/solib-frv.c @@ -377,7 +377,7 @@ frv_current_sos (void) if (got_addr != mgot) { int errcode; - char *name_buf; + gdb::unique_xmalloc_ptr<char> name_buf; struct int_elf32_fdpic_loadmap *loadmap; struct so_list *sop; CORE_ADDR addr; @@ -409,16 +409,16 @@ frv_current_sos (void) if (solib_frv_debug) fprintf_unfiltered (gdb_stdlog, "current_sos: name = %s\n", - name_buf); + name_buf.get ()); if (errcode != 0) warning (_("Can't read pathname for link map entry: %s."), safe_strerror (errcode)); else { - strncpy (sop->so_name, name_buf, SO_NAME_MAX_PATH_SIZE - 1); + strncpy (sop->so_name, name_buf.get (), + SO_NAME_MAX_PATH_SIZE - 1); sop->so_name[SO_NAME_MAX_PATH_SIZE - 1] = '\0'; - xfree (name_buf); strcpy (sop->so_original_name, sop->so_name); } |