diff options
author | Pedro Alves <palves@redhat.com> | 2020-01-10 20:05:44 +0000 |
---|---|---|
committer | Pedro Alves <palves@redhat.com> | 2020-01-10 20:05:44 +0000 |
commit | 5018ce90c1205d79f29adf954b0fd5e613d08430 (patch) | |
tree | db2d71399b20052fd76eb3a4ca9bba47485d3eae /gdb/process-stratum-target.c | |
parent | 74375d182e992778ef8701278c02a742db6be77e (diff) | |
download | fsf-binutils-gdb-5018ce90c1205d79f29adf954b0fd5e613d08430.zip fsf-binutils-gdb-5018ce90c1205d79f29adf954b0fd5e613d08430.tar.gz fsf-binutils-gdb-5018ce90c1205d79f29adf954b0fd5e613d08430.tar.bz2 |
Make target_ops::has_execution take an 'inferior *' instead of a ptid_t
With the multi-target work, each inferior will have its own target
stack, so to call a target method, we'll need to make sure that the
inferior in question is the current one, otherwise target->beneath()
calls will find the target beneath in the wrong inferior.
In some places, it's much more convenient to be able to check whether
an inferior has execution without having to switch to it in order to
call target_has_execution on the right inferior/target stack, to avoid
side effects with switching inferior/thread/program space.
The current target_ops::has_execution method takes a ptid_t as
parameter, which, in a multi-target world, isn't sufficient to
identify the target. This patch prepares to address that, by changing
the parameter to an inferior pointer instead. From the inferior,
we'll be able to query its target stack to tell which target is
beneath.
Also adds a new inferior::has_execution() method to make callers a bit
more natural to read.
gdb/ChangeLog:
2020-01-10 Pedro Alves <palves@redhat.com>
* corelow.c (core_target::has_execution): Change parameter type to
inferior pointer.
* inferior.c (number_of_live_inferiors): Use
inferior::has_execution instead of target_has_execution_1.
* inferior.h (inferior::has_execution): New.
* linux-thread-db.c (thread_db_target::update_thread_list): Use
inferior::has_execution instead of target_has_execution_1.
* process-stratum-target.c
(process_stratum_target::has_execution): Change parameter type to
inferior pointer. Check the inferior's PID instead of
inferior_ptid.
* process-stratum-target.h
(process_stratum_target::has_execution): Change parameter type to
inferior pointer.
* record-full.c (record_full_core_target::has_execution): Change
parameter type to inferior pointer.
* target.c (target_has_execution_1): Change parameter type to
inferior pointer.
(target_has_execution_current): Adjust.
* target.h (target_ops::has_execution): Change parameter type to
inferior pointer.
(target_has_execution_1): Change parameter type to inferior
pointer. Change return type to bool.
* tracefile.h (tracefile_target::has_execution): Change parameter
type to inferior pointer.
Diffstat (limited to 'gdb/process-stratum-target.c')
-rw-r--r-- | gdb/process-stratum-target.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/gdb/process-stratum-target.c b/gdb/process-stratum-target.c index d6bc6ab..658229f 100644 --- a/gdb/process-stratum-target.c +++ b/gdb/process-stratum-target.c @@ -77,9 +77,9 @@ process_stratum_target::has_registers () } bool -process_stratum_target::has_execution (ptid_t the_ptid) +process_stratum_target::has_execution (inferior *inf) { - /* If there's no thread selected, then we can't make it run through - hoops. */ - return the_ptid != null_ptid; + /* If there's a process running already, we can't make it run + through hoops. */ + return inf->pid != 0; } |