aboutsummaryrefslogtreecommitdiff
path: root/gdb/minsyms.c
diff options
context:
space:
mode:
authorSimon Marchi <simon.marchi@ericsson.com>2018-05-20 21:07:03 -0400
committerSimon Marchi <simon.marchi@polymtl.ca>2018-05-20 21:07:03 -0400
commite39db4db7c553ae1c4aaf158cd0ebf3cf6d478fb (patch)
tree2359e7636c59454aaa20888b481f5ad5b6d09b60 /gdb/minsyms.c
parent284a0e3cbffa92ee5c94065fcdd5a528482344fc (diff)
downloadfsf-binutils-gdb-e39db4db7c553ae1c4aaf158cd0ebf3cf6d478fb.zip
fsf-binutils-gdb-e39db4db7c553ae1c4aaf158cd0ebf3cf6d478fb.tar.gz
fsf-binutils-gdb-e39db4db7c553ae1c4aaf158cd0ebf3cf6d478fb.tar.bz2
Use XOBNEW/XOBNEWVEC/OBSTACK_ZALLOC when possible
Since XOBNEW/XOBNEWVEC/OBSTACK_ZALLOC are now poisoned to prevent using them with non-trivially-constructible objects, it is worth using them over plain obstack_alloc. This patch changes the locations I could find where we can do that change easily. gdb/ChangeLog: * ada-lang.c (cache_symbol): Use XOBNEW and/or XOBNEWVEC and/or OBSTACK_ZALLOC. * dwarf2-frame.c (dwarf2_build_frame_info): Likewise. * hppa-tdep.c (hppa_init_objfile_priv_data): Likewise. * mdebugread.c (mdebug_build_psymtabs): Likewise. (add_pending): Likewise. (parse_symbol): Likewise. (parse_partial_symbols): Likewise. (psymtab_to_symtab_1): Likewise. (new_psymtab): Likewise. (elfmdebug_build_psymtabs): Likewise. * minsyms.c (terminate_minimal_symbol_table): Likewise. * objfiles.c (get_objfile_bfd_data): Likewise. (objfile_register_static_link): Likewise. * psymtab.c (allocate_psymtab): Likewise. * stabsread.c (read_member_functions): Likewise. * xcoffread.c (xcoff_end_psymtab): Likewise.
Diffstat (limited to 'gdb/minsyms.c')
-rw-r--r--gdb/minsyms.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/gdb/minsyms.c b/gdb/minsyms.c
index 496dba0..b98f121 100644
--- a/gdb/minsyms.c
+++ b/gdb/minsyms.c
@@ -1419,10 +1419,8 @@ void
terminate_minimal_symbol_table (struct objfile *objfile)
{
if (! objfile->per_bfd->msymbols)
- objfile->per_bfd->msymbols
- = ((struct minimal_symbol *)
- obstack_alloc (&objfile->per_bfd->storage_obstack,
- sizeof (struct minimal_symbol)));
+ objfile->per_bfd->msymbols = XOBNEW (&objfile->per_bfd->storage_obstack,
+ minimal_symbol);
{
struct minimal_symbol *m