aboutsummaryrefslogtreecommitdiff
path: root/gdb/infcmd.c
diff options
context:
space:
mode:
authorMarkus Metzger <markus.t.metzger@intel.com>2014-06-30 11:47:30 +0200
committerMarkus Metzger <markus.t.metzger@intel.com>2014-07-08 10:07:59 +0200
commit1f267ae3d18c165f8b4327aa423b909eae92f4d6 (patch)
tree4eaef7f48e16ab997d1ca1acecc7e28277eacf92 /gdb/infcmd.c
parent37a6ac445daf5075d9058d7f01505f96a43f592a (diff)
downloadfsf-binutils-gdb-1f267ae3d18c165f8b4327aa423b909eae92f4d6.zip
fsf-binutils-gdb-1f267ae3d18c165f8b4327aa423b909eae92f4d6.tar.gz
fsf-binutils-gdb-1f267ae3d18c165f8b4327aa423b909eae92f4d6.tar.bz2
reverse-finish: turn internal error into normal error
The reverse-finish command results in an internal error if it cannot determine the current function. (gdb) c Continuing. Program received signal SIGSEGV, Segmentation fault. 0x0000000000000000 in ?? () (gdb) reverse-finish Run back to call of #0 0x0000000000000000 in ?? () gdb/infcmd.c:1576: internal-error: Finish: couldn't find function. A problem internal to GDB has been detected, further debugging may prove unreliable. Quit this debugging session? (y or n) y This is not an internal error case since the command may be used in scenarios where there is no function at the current PC, e.g. after calling through a bad function pointer. Turn this into a normal error. gdb/ * infcmd.c (finish_backward): Turn internal error into normal error. testsuite/ * gdb.btrace/segv.c: New. * gdb.btrace/segv.exp: New.
Diffstat (limited to 'gdb/infcmd.c')
-rw-r--r--gdb/infcmd.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/gdb/infcmd.c b/gdb/infcmd.c
index c4bb401..14736a5 100644
--- a/gdb/infcmd.c
+++ b/gdb/infcmd.c
@@ -1573,8 +1573,7 @@ finish_backward (struct symbol *function)
pc = get_frame_pc (get_current_frame ());
if (find_pc_partial_function (pc, NULL, &func_addr, NULL) == 0)
- internal_error (__FILE__, __LINE__,
- _("Finish: couldn't find function."));
+ error (_("Cannot find bounds of current function"));
sal = find_pc_line (func_addr, 0);