aboutsummaryrefslogtreecommitdiff
path: root/gdb/i386-linux-tdep.c
diff options
context:
space:
mode:
authorJon Turney <jon.turney@dronecode.org.uk>2016-09-26 15:45:28 +0100
committerJon Turney <jon.turney@dronecode.org.uk>2018-09-23 16:15:19 +0100
commita44294f5ed9fe09fdfc9427f6f83677843590524 (patch)
tree1357139f02916e275f2c30add22d42c292eec043 /gdb/i386-linux-tdep.c
parent0c0a40e0abb9f1a584330a1911ad06b3686e5361 (diff)
downloadfsf-binutils-gdb-a44294f5ed9fe09fdfc9427f6f83677843590524.zip
fsf-binutils-gdb-a44294f5ed9fe09fdfc9427f6f83677843590524.tar.gz
fsf-binutils-gdb-a44294f5ed9fe09fdfc9427f6f83677843590524.tar.bz2
Remove a spurious target_terminal::ours() from windows_nat_target::wait()
This causes the inferior to stop with SIGTTIN if it tries to read from the terminal after it has been continued. See https://cygwin.com/ml/cygwin/2016-09/msg00285.html for reproduction. Since MinGW doesn't have a tcsetpgrp(), I don't think this problem would be observed there, but Cygwin does so target_terminal::ours() will call it. Calling target_terminal::ours() here seems to be is no longer appropriate after the "Merge async and sync code paths" changes (as the inferior is now in a separate process group even in sync mode(?), which is always used on Windows targets) This call was added in commit c44537cf (and see https://sourceware.org/ml/gdb-patches/2007-02/msg00167.html for what it fixed, which is not regressed by this change) When windows_nat_target::wait() is entered, the inferior is running (either it's been just been started or attached to, or windows_continue() was called), so grabbing the controlling terminal away from it here seems to be wrong, since infrun.c takes care of calling target_terminal::ours() when the inferior stops. gdb/ChangeLog: 2018-08-02 Jon Turney <jon.turney@dronecode.org.uk> * windows-nat.c (windows_nat_target::wait): Remove a spurious target_terminal::ours().
Diffstat (limited to 'gdb/i386-linux-tdep.c')
0 files changed, 0 insertions, 0 deletions