diff options
author | Pedro Alves <palves@redhat.com> | 2018-06-28 20:18:24 +0100 |
---|---|---|
committer | Pedro Alves <palves@redhat.com> | 2018-06-28 17:12:07 +0100 |
commit | f2ffa92bbce9dd5fbedc138ac2a3bc8a88327d09 (patch) | |
tree | 82502f3011afcdbad7b679a956cea3d1a4f203b2 /gdb/gdbthread.h | |
parent | ecdc3a72c89e43e0e13c5478723b4f70b3964e9f (diff) | |
download | fsf-binutils-gdb-f2ffa92bbce9dd5fbedc138ac2a3bc8a88327d09.zip fsf-binutils-gdb-f2ffa92bbce9dd5fbedc138ac2a3bc8a88327d09.tar.gz fsf-binutils-gdb-f2ffa92bbce9dd5fbedc138ac2a3bc8a88327d09.tar.bz2 |
gdb: Eliminate the 'stop_pc' global
In my multi-target work, I need to add a few more
scoped_restore_current_thread and switch_to_thread calls in some
places, and in some lower-level places I was fighting against the fact
that switch_to_thread reads/refreshes the stop_pc global.
Instead of piling on workarounds, let's just finally eliminate the
stop_pc global. We already have the per-thread
thread_info->suspend.stop_pc field, so it's mainly a matter of using
that more/instead.
gdb/ChangeLog:
2018-06-28 Pedro Alves <palves@redhat.com>
* gdbthread.h (struct thread_suspend_state) <stop_pc>: Extend
comments.
(switch_to_thread_no_regs): Adjust comment.
* infcmd.c (stop_pc): Delete.
(post_create_inferior, info_program_command): Replace references
to stop_pc with references to thread_info->suspend.stop_pc.
* inferior.h (stop_pc): Delete declaration.
* infrun.c (proceed, handle_syscall_event, fill_in_stop_func)
(handle_inferior_event_1, handle_signal_stop)
(process_event_stop_test, keep_going_stepped_thread)
(handle_step_into_function, handle_step_into_function_backward)
(print_stop_location): Replace references to stop_pc with
references to thread_info->suspend.stop_pc.
(struct infcall_suspend_state) <stop_pc>: Delete field.
(save_infcall_suspend_state, restore_infcall_suspend_state):
Remove references to inf_stat->stop_pc.
* linux-fork.c (fork_load_infrun_state): Likewise.
* record-btrace.c (record_btrace_set_replay): Likewise.
* record-full.c (record_full_goto_entry): Likewise.
* remote.c (print_one_stopped_thread): Likewise.
* target.c (target_resume): Extend comment.
* thread.c (set_executing_thread): New.
(set_executing): Use it.
(switch_to_thread_no_regs, switch_to_no_thread, switch_to_thread):
Remove references to stop_pc.
Diffstat (limited to 'gdb/gdbthread.h')
-rw-r--r-- | gdb/gdbthread.h | 20 |
1 files changed, 14 insertions, 6 deletions
diff --git a/gdb/gdbthread.h b/gdb/gdbthread.h index ec607bb..714fb63 100644 --- a/gdb/gdbthread.h +++ b/gdb/gdbthread.h @@ -168,10 +168,19 @@ struct thread_suspend_state /* Record the pc of the thread the last time it stopped. (This is not the current thread's PC as that may have changed since the - last stop, e.g., "return" command, or "p $pc = 0xf000"). This is - used in coordination with stop_reason and waitstatus_pending_p: - if the thread's PC is changed since it last stopped, a pending - breakpoint waitstatus is discarded. */ + last stop, e.g., "return" command, or "p $pc = 0xf000"). + + - If the thread's PC has not changed since the thread last + stopped, then proceed skips a breakpoint at the current PC, + otherwise we let the thread run into the breakpoint. + + - If the thread has an unprocessed event pending, as indicated by + waitstatus_pending_p, this is used in coordination with + stop_reason: if the thread's PC has changed since the thread + last stopped, a pending breakpoint waitstatus is discarded. + + - If the thread is running, this is set to -1, to avoid leaving + it with a stale value, to make it easier to catch bugs. */ CORE_ADDR stop_pc; }; @@ -498,8 +507,7 @@ extern void switch_to_thread (struct thread_info *thr); /* Switch context to no thread selected. */ extern void switch_to_no_thread (); -/* Switch from one thread to another. Does not read registers and - sets STOP_PC to -1. */ +/* Switch from one thread to another. Does not read registers. */ extern void switch_to_thread_no_regs (struct thread_info *thread); /* Marks or clears thread(s) PTID as resumed. If PTID is |