diff options
| author | Alan Hayward <alan.hayward@arm.com> | 2019-04-12 14:21:55 +0100 |
|---|---|---|
| committer | Alan Hayward <alan.hayward@arm.com> | 2019-04-17 09:54:47 +0100 |
| commit | c1bc0935a4afb513486dc0a479cd57c0924b677c (patch) | |
| tree | 18dcc642b0a0f8dc4846bf13552f2dbe71a506bc /gdb/gdbserver/hostio.c | |
| parent | 1cfe2726f1564df1247f7844077717db04522a88 (diff) | |
| download | fsf-binutils-gdb-c1bc0935a4afb513486dc0a479cd57c0924b677c.zip fsf-binutils-gdb-c1bc0935a4afb513486dc0a479cd57c0924b677c.tar.gz fsf-binutils-gdb-c1bc0935a4afb513486dc0a479cd57c0924b677c.tar.bz2 | |
gdbserver: Move remote_debug to a single place
A comment in debug.h (written in 2014) states: "We declare debug format
variables here, and debug_threads but no other debug content variables
(e.g., not remote_debug) because while this file is not currently used by
IPA it may be some day, and IPA may have its own set of debug content
variables".
This has resulted in remote_debug being declared in many .c/.h files
throughout gdbserver.
It would be much simplier to define it one place. The most logical place to
define it is in debug.h, surrounded by #define guards. If IPA is changed,
then at that point the variable can be moved elsewhere.
gdb/gdbserver/ChangeLog:
* debug.c (remote_debug): Add definition.
* debug.h (remote_debug): Add declaration.
* hostio.c (remote_debug): Remove declaration.
* remote-utils.c (struct ui_file): Likewise.
(remote_debug): Likewise.
* remote-utils.h (remote_debug): Likewise,
* server.c (remote_debug): Remove definition.
Diffstat (limited to 'gdb/gdbserver/hostio.c')
| -rw-r--r-- | gdb/gdbserver/hostio.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/gdb/gdbserver/hostio.c b/gdb/gdbserver/hostio.c index cf75de0..eedf6d9 100644 --- a/gdb/gdbserver/hostio.c +++ b/gdb/gdbserver/hostio.c @@ -29,8 +29,6 @@ #include <sys/stat.h> #include "common/fileio.h" -extern int remote_debug; - struct fd_list { int fd; |