diff options
| author | Andrew Burgess <andrew.burgess@embecosm.com> | 2019-07-02 12:06:06 +0100 |
|---|---|---|
| committer | Andrew Burgess <andrew.burgess@embecosm.com> | 2019-07-17 16:24:32 +0100 |
| commit | 6b78c3f83c8bcbfa714aab7627ece9673b2d602a (patch) | |
| tree | e8224084dbf069be1e592ea23aeefc509ddf1316 /gdb/gdbarch.c | |
| parent | d72a9b85651c872378f6dd732cb578f6f055a9b3 (diff) | |
| download | fsf-binutils-gdb-6b78c3f83c8bcbfa714aab7627ece9673b2d602a.zip fsf-binutils-gdb-6b78c3f83c8bcbfa714aab7627ece9673b2d602a.tar.gz fsf-binutils-gdb-6b78c3f83c8bcbfa714aab7627ece9673b2d602a.tar.bz2 | |
gdb: Remove a non-const reference parameter
Non-const reference parameter should be avoided according to the GDB
coding standard:
https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#Avoid_non-const_reference_parameters.2C_use_pointers_instead
This commit updates the gdbarch method gdbarch_stap_adjust_register,
and the one implementation i386_stap_adjust_register to avoid using a
non-const reference parameter.
I've also removed the kfail from the testsuite for bug 24541, as this
issue is now resolved.
gdb/ChangeLog:
PR breakpoints/24541
* gdbarch.c: Regenerate.
* gdbarch.h: Regenerate.
* gdbarch.sh: Adjust return type and parameter types for
'stap_adjust_register'.
(i386_stap_adjust_register): Adjust signature and return new
register name.
* stap-probe.c (stap_parse_register_operand): Adjust use of
'gdbarch_stap_adjust_register'.
gdb/testsuite/ChangeLog:
PR breakpoints/24541
* gdb.mi/mi-catch-cpp-exceptions.exp: Remove kfail due to 24541.
Diffstat (limited to 'gdb/gdbarch.c')
| -rw-r--r-- | gdb/gdbarch.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/gdb/gdbarch.c b/gdb/gdbarch.c index cc7d0ac..725b98f 100644 --- a/gdb/gdbarch.c +++ b/gdb/gdbarch.c @@ -4530,14 +4530,14 @@ gdbarch_stap_adjust_register_p (struct gdbarch *gdbarch) return gdbarch->stap_adjust_register != NULL; } -void -gdbarch_stap_adjust_register (struct gdbarch *gdbarch, struct stap_parse_info *p, std::string ®name, int regnum) +std::string +gdbarch_stap_adjust_register (struct gdbarch *gdbarch, struct stap_parse_info *p, const std::string ®name, int regnum) { gdb_assert (gdbarch != NULL); gdb_assert (gdbarch->stap_adjust_register != NULL); if (gdbarch_debug >= 2) fprintf_unfiltered (gdb_stdlog, "gdbarch_stap_adjust_register called\n"); - gdbarch->stap_adjust_register (gdbarch, p, regname, regnum); + return gdbarch->stap_adjust_register (gdbarch, p, regname, regnum); } void |