diff options
| author | Tom de Vries <tdevries@suse.de> | 2021-08-23 12:08:25 +0200 |
|---|---|---|
| committer | Tom de Vries <tdevries@suse.de> | 2021-08-23 12:08:25 +0200 |
| commit | a9680e0e54cfd8a12ddb1a583b4acb96dc2bbdbd (patch) | |
| tree | c651b3845c15b82d0d4b3b0c9a20bbc24f2897a3 /gdb/exec.c | |
| parent | 74cdc3e0888f1ffc3973a4826e85dd32e5a51037 (diff) | |
| download | fsf-binutils-gdb-a9680e0e54cfd8a12ddb1a583b4acb96dc2bbdbd.zip fsf-binutils-gdb-a9680e0e54cfd8a12ddb1a583b4acb96dc2bbdbd.tar.gz fsf-binutils-gdb-a9680e0e54cfd8a12ddb1a583b4acb96dc2bbdbd.tar.bz2 | |
[gdb] Fix 'not in executable format' error message
With trying to load a non-executable file into gdb, we run into PR26880:
...
$ gdb -q -batch test.c
"0x7ffc87bfc8d0s": not in executable format: \
file format not recognized
...
The problem is caused by using %ps in combination with the error function
(note that confusingly, it does work in combination with the warning
function).
Fix this by using plain "%s" instead.
Tested on x86_64-linux.
gdb/ChangeLog:
2021-08-22 Tom de Vries <tdevries@suse.de>
PR gdb/26880
* gdb/exec.c (exec_file_attach): Use %s instead of %ps in call to
error function.
gdb/testsuite/ChangeLog:
2021-08-22 Tom de Vries <tdevries@suse.de>
PR gdb/26880
* gdb.base/non-executable.exp: New file.
Diffstat (limited to 'gdb/exec.c')
| -rw-r--r-- | gdb/exec.c | 8 |
1 files changed, 3 insertions, 5 deletions
@@ -453,9 +453,8 @@ exec_file_attach (const char *filename, int from_tty) if (!current_program_space->exec_bfd ()) { - error (_("\"%ps\": could not open as an executable file: %s."), - styled_string (file_name_style.style (), scratch_pathname), - bfd_errmsg (bfd_get_error ())); + error (_("\"%s\": could not open as an executable file: %s."), + scratch_pathname, bfd_errmsg (bfd_get_error ())); } /* gdb_realpath_keepfile resolves symlinks on the local @@ -475,8 +474,7 @@ exec_file_attach (const char *filename, int from_tty) /* Make sure to close exec_bfd, or else "run" might try to use it. */ current_program_space->exec_close (); - error (_("\"%ps\": not in executable format: %s"), - styled_string (file_name_style.style (), scratch_pathname), + error (_("\"%s\": not in executable format: %s"), scratch_pathname, gdb_bfd_errmsg (bfd_get_error (), matching).c_str ()); } |