diff options
author | Gary Benson <gbenson@redhat.com> | 2014-09-11 11:43:04 +0100 |
---|---|---|
committer | Gary Benson <gbenson@redhat.com> | 2014-09-11 11:43:21 +0100 |
commit | bd9269f70c70b1218b0eb73a6f487d6ca481e5ac (patch) | |
tree | 87a113269227ef0da65e91772516f107efdaac2b /gdb/common | |
parent | f8c1d06b82ab0fd56bcffc9030cb44b5a946113e (diff) | |
download | fsf-binutils-gdb-bd9269f70c70b1218b0eb73a6f487d6ca481e5ac.zip fsf-binutils-gdb-bd9269f70c70b1218b0eb73a6f487d6ca481e5ac.tar.gz fsf-binutils-gdb-bd9269f70c70b1218b0eb73a6f487d6ca481e5ac.tar.bz2 |
Introduce common/symbol.h
This introduces common/symbol.h. This file declares a function that
the shared code can use and that the clients must implement. It also
changes some shared code to use these functions.
gdb/ChangeLog:
* common/symbol.h: New file.
* Makefile.in (HFILES_NO_SRCDIR): Add common/symbol.h.
* minsyms.c (find_minimal_symbol_address): New function.
* common/agent.c: Include common/symbol.h.
[!GDBSERVER]: Don't include objfiles.h.
(agent_look_up_symbols): Use find_minimal_symbol_address.
gdb/gdbserver/ChangeLog:
* symbol.c: New file.
* Makefile.in (SFILES): Add symbol.c.
(OBS): Add symbol.o.
Diffstat (limited to 'gdb/common')
-rw-r--r-- | gdb/common/agent.c | 15 | ||||
-rw-r--r-- | gdb/common/symbol.h | 37 |
2 files changed, 40 insertions, 12 deletions
diff --git a/gdb/common/agent.c b/gdb/common/agent.c index 0ac73a9..433ae2a 100644 --- a/gdb/common/agent.c +++ b/gdb/common/agent.c @@ -21,9 +21,9 @@ #include "server.h" #else #include "defs.h" -#include "objfiles.h" #endif #include "target/target.h" +#include "common/symbol.h" #include <unistd.h> #include "agent.h" #include "filestuff.h" @@ -98,18 +98,9 @@ agent_look_up_symbols (void *arg) { CORE_ADDR *addrp = (CORE_ADDR *) ((char *) &ipa_sym_addrs + symbol_list[i].offset); -#ifdef GDBSERVER - - if (look_up_one_symbol (symbol_list[i].name, addrp, 1) == 0) -#else - struct bound_minimal_symbol sym = - lookup_minimal_symbol (symbol_list[i].name, NULL, - (struct objfile *) arg); - if (sym.minsym != NULL) - *addrp = BMSYMBOL_VALUE_ADDRESS (sym); - else -#endif + if (find_minimal_symbol_address (symbol_list[i].name, addrp, + arg) != 0) { DEBUG_AGENT ("symbol `%s' not found\n", symbol_list[i].name); return -1; diff --git a/gdb/common/symbol.h b/gdb/common/symbol.h new file mode 100644 index 0000000..723d7fa --- /dev/null +++ b/gdb/common/symbol.h @@ -0,0 +1,37 @@ +/* Declarations of common symbol functions. + + Copyright (C) 2014 Free Software Foundation, Inc. + + This file is part of GDB. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +#ifndef COMMON_SYMBOL_H +#define COMMON_SYMBOL_H + +struct objfile; + +/* Find a symbol that matches NAME. Limit the search to OBJFILE if + OBJFILE is non-NULL and the implementation supports limiting the + search to specific object files. NAME may be mangled or demangled. + If a match is found, store the matching symbol's address in ADDR + and return zero. Returns nonzero if no symbol matching NAME is + found. Raise an exception if OBJFILE is non-NULL and the + implementation does not support limiting searches to specific + object files. This function must be provided by the client. */ + +extern int find_minimal_symbol_address (const char *name, CORE_ADDR *addr, + struct objfile *objfile); + +#endif /* COMMON_SYMBOL_H */ |