diff options
author | Christian Biesinger <cbiesinger@google.com> | 2019-10-03 00:36:35 -0500 |
---|---|---|
committer | Christian Biesinger <cbiesinger@google.com> | 2019-10-19 15:45:33 -0500 |
commit | 39ef2f6256737db92f5d60fa201fe0b301bb8100 (patch) | |
tree | 13ff1a57f5ecac08df8f0ecdc2f3544cb4d97564 /gdb/bcache.c | |
parent | 18338fcee6c75bf0b41f803b84ae15221676f8cd (diff) | |
download | fsf-binutils-gdb-39ef2f6256737db92f5d60fa201fe0b301bb8100.zip fsf-binutils-gdb-39ef2f6256737db92f5d60fa201fe0b301bb8100.tar.gz fsf-binutils-gdb-39ef2f6256737db92f5d60fa201fe0b301bb8100.tar.bz2 |
Replace some more qsort calls with std::sort
This has better typesafety, avoids a function pointer indirection,
and can benefit from inlining.
gdb/ChangeLog:
2019-10-19 Christian Biesinger <cbiesinger@google.com>
* bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
* breakpoint.c (bp_locations_compare): Rename to...
(bp_location_is_less_than): ...this, and change to std::sort semantics.
(update_global_location_list): Use std::sort instead of qsort.
* buildsym.c (compare_line_numbers): Rename to...
(lte_is_less_than): ...this, and change to std::sort semantics.
(buildsym_compunit::end_symtab_with_blockvector): Use std::sort
instead of qsort.
* disasm.c (compare_lines): Rename to...
(line_is_less_than): ...this, and change to std::sort semantics.
(do_mixed_source_and_assembly_deprecated): Call std::sort instead
of qsort.
* dwarf2-frame.c (qsort_fde_cmp): Rename to...
(fde_is_less_than): ...this, and change to std::sort semantics.
(dwarf2_build_frame_info): Call std::sort instead of qsort.
* mdebugread.c (compare_blocks):
(block_is_less_than): ...this, and change to std::sort semantics.
(sort_blocks): Call std::sort instead of qsort.
* objfiles.c (qsort_cmp): Rename to...
(sort_cmp): ...this, and change to std::sort semantics.
(update_section_map): Call std::sort instead of qsort.
* remote.c (compare_pnums): Remove.
(map_regcache_remote_table): Call std::sort instead of qsort.
* utils.c (compare_positive_ints): Remove.
* utils.h (compare_positive_ints): Remove.
* xcoffread.c (compare_lte): Remove.
(arrange_linetable): Call std::sort instead of qsort.
Change-Id: Ibcddce12a3d07448701e731b7150fa23611d86de
Diffstat (limited to 'gdb/bcache.c')
-rw-r--r-- | gdb/bcache.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/gdb/bcache.c b/gdb/bcache.c index 14a7847..3f0a63b 100644 --- a/gdb/bcache.c +++ b/gdb/bcache.c @@ -23,6 +23,8 @@ #include "gdb_obstack.h" #include "bcache.h" +#include <algorithm> + /* The type used to hold a single bcache string. The user data is stored in d.data. Since it can be any type, it needs to have the same alignment as the most strict alignment of any type on the host @@ -311,10 +313,8 @@ bcache::print_statistics (const char *type) /* To compute the median, we need the set of chain lengths sorted. */ - qsort (chain_length, m_num_buckets, sizeof (chain_length[0]), - compare_positive_ints); - qsort (entry_size, m_unique_count, sizeof (entry_size[0]), - compare_positive_ints); + std::sort (chain_length, chain_length + m_num_buckets); + std::sort (entry_size, entry_size + m_unique_count); if (m_num_buckets > 0) { |