diff options
| author | Christian Biesinger <cbiesinger@google.com> | 2019-08-28 15:40:31 -0500 |
|---|---|---|
| committer | Christian Biesinger <cbiesinger@google.com> | 2019-09-23 13:36:34 -0500 |
| commit | f945dedfd3512bfbca0f1405c8ea85684980e69a (patch) | |
| tree | 706c59bb9ef87edd16339939c6b547c72494bfcd /gdb/ada-varobj.c | |
| parent | 4a41f3face78a551ea5c85db24125989754f2ee8 (diff) | |
| download | fsf-binutils-gdb-f945dedfd3512bfbca0f1405c8ea85684980e69a.zip fsf-binutils-gdb-f945dedfd3512bfbca0f1405c8ea85684980e69a.tar.gz fsf-binutils-gdb-f945dedfd3512bfbca0f1405c8ea85684980e69a.tar.bz2 | |
Make ada_decode not use a static buffer
This makes it safer to use in general, and also allows using it on a
background thread in the future.
Inspired by tromey's patch at:
https://github.com/tromey/gdb/commit/1226cbdfa436297a5dec054d94592c45891afa93
(however, implemented in a different way)
gdb/ChangeLog:
2019-09-23 Christian Biesinger <cbiesinger@google.com>
* ada-exp.y (write_object_remaining): Update.
* ada-lang.c (ada_decode): Return a std::string instead of a char*
and eliminate the static buffer.
(ada_decode_symbol): Update.
(ada_la_decode): Update.
(ada_sniff_from_mangled_name): Update.
(is_valid_name_for_wild_match): Update.
(ada_lookup_name_info::matches): Update and simplify.
(name_matches_regex): Update.
(ada_add_global_exceptions): Update.
* ada-lang.h (ada_decode): Update signature.
* ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
* dwarf-index-write.c (debug_names::insert): Update.
Diffstat (limited to 'gdb/ada-varobj.c')
| -rw-r--r-- | gdb/ada-varobj.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/gdb/ada-varobj.c b/gdb/ada-varobj.c index a4d553d..1a5d0ac 100644 --- a/gdb/ada-varobj.c +++ b/gdb/ada-varobj.c @@ -624,6 +624,7 @@ ada_varobj_describe_simple_array_child (struct value *parent_value, of the array index type when such type qualification is needed. */ const char *index_type_name = NULL; + std::string decoded; /* If the index type is a range type, find the base type. */ while (TYPE_CODE (index_type) == TYPE_CODE_RANGE) @@ -634,7 +635,10 @@ ada_varobj_describe_simple_array_child (struct value *parent_value, { index_type_name = ada_type_name (index_type); if (index_type_name) - index_type_name = ada_decode (index_type_name); + { + decoded = ada_decode (index_type_name); + index_type_name = decoded.c_str (); + } } if (index_type_name != NULL) |