diff options
| author | Andrew Burgess <aburgess@redhat.com> | 2023-11-22 15:57:56 +0000 |
|---|---|---|
| committer | Andrew Burgess <aburgess@redhat.com> | 2023-12-08 17:52:00 +0000 |
| commit | 1753e2c3f6c7c5b639c816a89ba83bcbe8bebf4e (patch) | |
| tree | cce9bc1b61f4f365d380ce4f814207a04ed8720d /gdb/Makefile.in | |
| parent | 7543c960b00ddea23f6105eff4358ec214a7f93c (diff) | |
| download | fsf-binutils-gdb-1753e2c3f6c7c5b639c816a89ba83bcbe8bebf4e.zip fsf-binutils-gdb-1753e2c3f6c7c5b639c816a89ba83bcbe8bebf4e.tar.gz fsf-binutils-gdb-1753e2c3f6c7c5b639c816a89ba83bcbe8bebf4e.tar.bz2 | |
gdb: fix GDB_DEBUG and GDBSERVER_DEBUG Makefile variables
The gdb/testsuite/README file documents GDB_DEBUG and GDBSERVER_DEBUG
flags, which can be passed to make in order to enable debugging within
GDB or gdbserver respectively.
However, when I do:
make check-gdb GDB_DEBUG=infrun
I don't see the corresponding debug feature within GDB being enabled.
Nor does:
make check-gdb GDBSERVER_DEBUG=debug \
RUNTESTFLAGS="--target_board=native-extended-gdbserver"
Appear to enable gdbserver debugging.
I tracked this down to the GDB_DEBUG and GDBSERVER_DEBUG flags being
missing from the TARGET_FLAGS_TO_PASS variable in gdb/Makefile. This
variable already contains lots of testing related flags, like
RUNTESTFLAGS and TESTS, so I think it makes sense to add GDB_DEBUG and
GDBSERVER_DEBUG here too.
With this done, this debug feature is now working as expected.
Approved-By: Tom Tromey <tom@tromey.com>
Diffstat (limited to 'gdb/Makefile.in')
| -rw-r--r-- | gdb/Makefile.in | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/gdb/Makefile.in b/gdb/Makefile.in index 3510577..0886c0e 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -993,7 +993,10 @@ TARGET_FLAGS_TO_PASS = \ "RUNTEST=$(RUNTEST)" \ "RUNTESTFLAGS=$(RUNTESTFLAGS)" \ "FORCE_PARALLEL=$(FORCE_PARALLEL)" \ - "TESTS=$(TESTS)" + "TESTS=$(TESTS)" \ + "GDB_DEBUG=$(GDB_DEBUG)" \ + "GDBSERVER_DEBUG=$(GDBSERVER_DEBUG)" \ + # All source files that go into linking GDB. |