diff options
| author | Pedro Alves <palves@redhat.com> | 2015-01-14 12:43:30 +0000 |
|---|---|---|
| committer | Pedro Alves <palves@redhat.com> | 2015-01-14 12:43:30 +0000 |
| commit | e6da5aefd46143872f59cb0d88c36a6fd55b2bf3 (patch) | |
| tree | ae49ed4afb7bdde27b74a90c54f100e71166dd2b /gdb/ChangeLog | |
| parent | 17508220c32b7774027f364e5ba8579966ba404d (diff) | |
| download | fsf-binutils-gdb-e6da5aefd46143872f59cb0d88c36a6fd55b2bf3.zip fsf-binutils-gdb-e6da5aefd46143872f59cb0d88c36a6fd55b2bf3.tar.gz fsf-binutils-gdb-e6da5aefd46143872f59cb0d88c36a6fd55b2bf3.tar.bz2 | |
PR cli/17828: -batch -ex r breaks terminal
Commit d3d4baed (PR python/17372 - Python hangs when displaying
help()) had the side effect of causing 'gdb -batch' to leave the
terminal in the wrong state if the program was run. E.g,.
$ echo 'main(){*(int*)0=0;}' | gcc -x c -; ./gdb/gdb -batch -ex r ./a.out
Program received signal SIGSEGV, Segmentation fault.
0x00000000004004ff in main ()
$
If you start typing the next command, seemingly nothing happens - GDB
left the terminal with echo disabled.
The issue is that that "r" ends up in fetch_inferior_event, which
calls reinstall_readline_callback_handler_cleanup, which causes
readline to prep the terminal (raw, echo disabled). But "-batch"
causes GDB to exit before the top level event loop is first started,
and then nothing de-preps the terminal.
The reinstall_readline_callback_handler_cleanup function's intro
comment mentions:
"Need to do this as we go back to the event loop, ready to process
further input."
but the implementation forgets the case of when the interpreter is
sync, which indicates we won't return to the event loop yet, or as in
the case of -batch, we have not started it yet.
The fix is to not install the readline callback in that case.
For the test, in this case, checking that command echo still works is
sufficient. Comparing stty output before/after running GDB is even
better. Because stty may not be available, the test tries both ways.
In any case, since expect's spawn (what we use to start gdb) creates a
new pseudo tty, another expect spawn or tcl exec after GDB exits would
not see the wrong terminal settings. So instead, the test spawns a
shell and runs stty and GDB in it.
Tested on x86_64 Fedora 20.
gdb/
2015-01-14 Pedro Alves <palves@redhat.com>
PR cli/17828
* infrun.c (reinstall_readline_callback_handler_cleanup): Don't
reinstall if the interpreter is sync.
gdb/testsuite/
2015-01-14 Pedro Alves <palves@redhat.com>
PR cli/17828
* gdb.base/batch-preserve-term-settings.c: New file.
* gdb.base/batch-preserve-term-settings.exp: New file.
Diffstat (limited to 'gdb/ChangeLog')
| -rw-r--r-- | gdb/ChangeLog | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 1f821ba..640775c 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2015-01-14 Pedro Alves <palves@redhat.com> + + PR cli/17828 + * infrun.c (reinstall_readline_callback_handler_cleanup): Don't + reinstall if the interpreter is sync. + 2014-12-31 Joel Brobecker <brobecker@adacore.com> PR backtrace/16215: |