diff options
| author | Yao Qi <yao@codesourcery.com> | 2014-03-11 10:47:48 +0800 |
|---|---|---|
| committer | Yao Qi <yao@codesourcery.com> | 2014-03-22 18:31:30 +0800 |
| commit | 8acf9577e5acd99c23fe8f3fa87a961668de7805 (patch) | |
| tree | 23ca50f0997a15f90038522062faa4e75ab8cc9f /gdb/ChangeLog | |
| parent | 25d743f9e6f23ec5fc1529a56d7178ad9cfe5611 (diff) | |
| download | fsf-binutils-gdb-8acf9577e5acd99c23fe8f3fa87a961668de7805.zip fsf-binutils-gdb-8acf9577e5acd99c23fe8f3fa87a961668de7805.tar.gz fsf-binutils-gdb-8acf9577e5acd99c23fe8f3fa87a961668de7805.tar.bz2 | |
Move the traceframe_available_memory code from memory_xfer_partial_1 down to the targets
As a follow-up to
[PATCH 7/8] Adjust read_value_memory to use to_xfer_partial
https://sourceware.org/ml/gdb-patches/2014-02/msg00384.html
this patch moves traceframe_available_memory down to the target side.
After this patch, the gdb core code is cleaner, and code on handling
unavailable memory is moved to remote/tfile/ctf targets.
In details, this patch moves traceframe_available_memory code from
memory_xfer_partial_1 to remote target only, so remote target still
uses traceframe_info mechanism to check unavailable memory, and use
remote_ops to read them from read-only sections. We don't use
traceframe_info mechanism for tfile and ctf target, because it is
fast to iterate all traceframes from trace file, so the summary
information got from traceframe_info is not necessary.
This patch also moves two functions to remote.c from target.c,
because they are only used in remote.c. I'll clean them up in another
patch.
gdb:
2014-03-22 Yao Qi <yao@codesourcery.com>
* ctf.c (ctf_xfer_partial): Check the return value of
exec_read_partial_read_only, if it is not TARGET_XFER_OK,
return TARGET_XFER_UNAVAILABLE.
* tracefile-tfile.c (tfile_xfer_partial): Likewise.
* target.c (target_read_live_memory): Move it to remote.c.
(memory_xfer_live_readonly_partial): Likewise.
(memory_xfer_partial_1): Move some code to remote_read_bytes.
* remote.c (target_read_live_memory): Moved from target.c.
(memory_xfer_live_readonly_partial): Likewise.
(remote_read_bytes): New, factored out from
memory_xfer_partial_1.
Diffstat (limited to 'gdb/ChangeLog')
| -rw-r--r-- | gdb/ChangeLog | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index a1e8c34..14322db 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,17 @@ +2014-03-22 Yao Qi <yao@codesourcery.com> + + * ctf.c (ctf_xfer_partial): Check the return value of + exec_read_partial_read_only, if it is not TARGET_XFER_OK, + return TARGET_XFER_UNAVAILABLE. + * tracefile-tfile.c (tfile_xfer_partial): Likewise. + * target.c (target_read_live_memory): Move it to remote.c. + (memory_xfer_live_readonly_partial): Likewise. + (memory_xfer_partial_1): Move some code to remote_read_bytes. + * remote.c (target_read_live_memory): Moved from target.c. + (memory_xfer_live_readonly_partial): Likewise. + (remote_read_bytes): Factored out from + memory_xfer_partial_1. + 2014-03-21 Daniel Gutson <daniel.gutson@tallertechnologies.com> * extension.c (eval_ext_lang_from_control_command): Avoid dereferencing |