diff options
| author | Barnaby Wilks <Barnaby.Wilks@arm.com> | 2019-08-15 16:21:59 +0000 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2019-08-19 09:53:22 +0930 |
| commit | 72c03e30ae783a5f38a8c124588a4536ae06e6ef (patch) | |
| tree | 9ddd9dfec942846c67c1d7fe4f99676d2770ad9d /gas | |
| parent | 2c115c4f3cb57cfed7a1be5bbccf0f1bc6f7fdbc (diff) | |
| download | fsf-binutils-gdb-72c03e30ae783a5f38a8c124588a4536ae06e6ef.zip fsf-binutils-gdb-72c03e30ae783a5f38a8c124588a4536ae06e6ef.tar.gz fsf-binutils-gdb-72c03e30ae783a5f38a8c124588a4536ae06e6ef.tar.bz2 | |
Float16: Fix test failures for non ELF targets
The tests were failing due to md_atof trying to do word-wise endian
switching on the float16 (for little-endian targets sometimes
multi word values have their word order changed).
However since a float16 is only 1 word wide, it would end up writing
incorrect data, as you cannot switch the word order of just one word.
* config/tc-arm.c (md_atof): Add precision check. Formatting.
Diffstat (limited to 'gas')
| -rw-r--r-- | gas/ChangeLog | 4 | ||||
| -rw-r--r-- | gas/config/tc-arm.c | 49 |
2 files changed, 26 insertions, 27 deletions
diff --git a/gas/ChangeLog b/gas/ChangeLog index 3ac707c..51c6c87 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,7 @@ +2019-08-19 Barnaby Wilks <Barnaby.Wilks@arm.com> + + * config/tc-arm.c (md_atof): Add precision check. Formatting. + 2019-08-15 Nick Clifton <nickc@redhat.com> * po/sv.po: Updated Swedish translation. diff --git a/gas/config/tc-arm.c b/gas/config/tc-arm.c index e2b21ed..c58748d 100644 --- a/gas/config/tc-arm.c +++ b/gas/config/tc-arm.c @@ -1237,34 +1237,29 @@ md_atof (int type, char * litP, int * sizeP) input_line_pointer = t; *sizeP = prec * sizeof (LITTLENUM_TYPE); - if (target_big_endian) - { - for (i = 0; i < prec; i++) - { - md_number_to_chars (litP, (valueT) words[i], sizeof (LITTLENUM_TYPE)); - litP += sizeof (LITTLENUM_TYPE); - } - } + if (target_big_endian || prec == 1) + for (i = 0; i < prec; i++) + { + md_number_to_chars (litP, (valueT) words[i], sizeof (LITTLENUM_TYPE)); + litP += sizeof (LITTLENUM_TYPE); + } + else if (ARM_CPU_HAS_FEATURE (cpu_variant, fpu_endian_pure)) + for (i = prec - 1; i >= 0; i--) + { + md_number_to_chars (litP, (valueT) words[i], sizeof (LITTLENUM_TYPE)); + litP += sizeof (LITTLENUM_TYPE); + } else - { - if (ARM_CPU_HAS_FEATURE (cpu_variant, fpu_endian_pure)) - for (i = prec - 1; i >= 0; i--) - { - md_number_to_chars (litP, (valueT) words[i], sizeof (LITTLENUM_TYPE)); - litP += sizeof (LITTLENUM_TYPE); - } - else - /* For a 4 byte float the order of elements in `words' is 1 0. - For an 8 byte float the order is 1 0 3 2. */ - for (i = 0; i < prec; i += 2) - { - md_number_to_chars (litP, (valueT) words[i + 1], - sizeof (LITTLENUM_TYPE)); - md_number_to_chars (litP + sizeof (LITTLENUM_TYPE), - (valueT) words[i], sizeof (LITTLENUM_TYPE)); - litP += 2 * sizeof (LITTLENUM_TYPE); - } - } + /* For a 4 byte float the order of elements in `words' is 1 0. + For an 8 byte float the order is 1 0 3 2. */ + for (i = 0; i < prec; i += 2) + { + md_number_to_chars (litP, (valueT) words[i + 1], + sizeof (LITTLENUM_TYPE)); + md_number_to_chars (litP + sizeof (LITTLENUM_TYPE), + (valueT) words[i], sizeof (LITTLENUM_TYPE)); + litP += 2 * sizeof (LITTLENUM_TYPE); + } return NULL; } |