diff options
| author | H.J. Lu <hjl.tools@gmail.com> | 2015-05-01 08:29:16 -0700 |
|---|---|---|
| committer | H.J. Lu <hjl.tools@gmail.com> | 2015-05-01 08:29:16 -0700 |
| commit | 00923338dec84505addaf9cdeca2e9c844757824 (patch) | |
| tree | d903956db30bc8e6efc22951b65d4dda1ed897ae /gas/testsuite | |
| parent | b633b7258d319687ac625da1f1b9be20e3bdaedb (diff) | |
| download | fsf-binutils-gdb-00923338dec84505addaf9cdeca2e9c844757824.zip fsf-binutils-gdb-00923338dec84505addaf9cdeca2e9c844757824.tar.gz fsf-binutils-gdb-00923338dec84505addaf9cdeca2e9c844757824.tar.bz2 | |
Remove i386_elf_emit_arch_note
This x86 assembler patch:
https://sourceware.org/ml/binutils/2001-11/msg00344.html
generates a .note section for .arch directive so that GDB can tell which
architecture an i386 binary belongs:
https://sourceware.org/ml/binutils/2001-11/msg00271.html
However, x86 assembly code can have any instructions. A .note section
doesn't help. This patch removes it.
gas/
* config/tc-i386.c (i386_elf_emit_arch_note): Removed.
* config/tc-i386.h (md_end): Likewise.
(i386_elf_emit_arch_note): Likewise.
gas/testsuite/
* gas/i386/i386.exp: Run note.
* gas/i386/note.d: New file.
* gas/i386/note.s: Likewise.
Diffstat (limited to 'gas/testsuite')
| -rw-r--r-- | gas/testsuite/ChangeLog | 6 | ||||
| -rw-r--r-- | gas/testsuite/gas/i386/i386.exp | 2 | ||||
| -rw-r--r-- | gas/testsuite/gas/i386/note.d | 7 | ||||
| -rw-r--r-- | gas/testsuite/gas/i386/note.s | 2 |
4 files changed, 17 insertions, 0 deletions
diff --git a/gas/testsuite/ChangeLog b/gas/testsuite/ChangeLog index 6608a80..e1fda77 100644 --- a/gas/testsuite/ChangeLog +++ b/gas/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2015-05-01 H.J. Lu <hongjiu.lu@intel.com> + + * gas/i386/i386.exp: Run note. + * gas/i386/note.d: New file. + * gas/i386/note.s: Likewise. + 2015-04-30 Nick Clifton <nickc@redhat.com> PR gas/18347 diff --git a/gas/testsuite/gas/i386/i386.exp b/gas/testsuite/gas/i386/i386.exp index 26cb7ac..e1fdd18 100644 --- a/gas/testsuite/gas/i386/i386.exp +++ b/gas/testsuite/gas/i386/i386.exp @@ -392,6 +392,8 @@ if [expr ([istarget "i*86-*-*"] || [istarget "x86_64-*-*"]) && [gas_32_check]] run_dump_test "size-2" run_dump_test "size-3" run_dump_test "size-4" + + run_dump_test "note" } # This is a PE specific test. diff --git a/gas/testsuite/gas/i386/note.d b/gas/testsuite/gas/i386/note.d new file mode 100644 index 0000000..e7ad71d --- /dev/null +++ b/gas/testsuite/gas/i386/note.d @@ -0,0 +1,7 @@ +#as: -march=i686 +#readelf: -SW + +#failif +#... +[ ]*\[.*\][ ]+\.note[ ]+NOTE.* +#... diff --git a/gas/testsuite/gas/i386/note.s b/gas/testsuite/gas/i386/note.s new file mode 100644 index 0000000..1ff7c29 --- /dev/null +++ b/gas/testsuite/gas/i386/note.s @@ -0,0 +1,2 @@ + .text + nop |