diff options
| author | Maciej W. Rozycki <macro@imgtec.com> | 2017-04-12 00:02:13 +0100 |
|---|---|---|
| committer | Maciej W. Rozycki <macro@imgtec.com> | 2017-04-25 21:10:53 +0100 |
| commit | 919383ac718c2a3187ee2a9ad659daa22da26258 (patch) | |
| tree | a1cf3be5f9d47fa372cacf62326c1fdd7cd83c0f /binutils | |
| parent | 126124cc0f3f0417913bfd84d83e4e525b6facf9 (diff) | |
| download | fsf-binutils-gdb-919383ac718c2a3187ee2a9ad659daa22da26258.zip fsf-binutils-gdb-919383ac718c2a3187ee2a9ad659daa22da26258.tar.gz fsf-binutils-gdb-919383ac718c2a3187ee2a9ad659daa22da26258.tar.bz2 | |
MIPS/readelf: Remove extraneous null GOT data check
Null data is handled gracefully throughout in MIPS GOT processing, with
addresses printed normally and unavailable data shown as `<unknown>' by
`print_mips_got_entry', and special processing code for GOT[1] doing an
explicit check. Remove an unwanted null GOT data check then, introduced
with commit 592458412fb2 in the course of addressing PR binutils/12855.
binutils/
* readelf.c (process_mips_specific): Remove null GOT data check.
Diffstat (limited to 'binutils')
| -rw-r--r-- | binutils/ChangeLog | 4 | ||||
| -rw-r--r-- | binutils/readelf.c | 3 |
2 files changed, 5 insertions, 2 deletions
diff --git a/binutils/ChangeLog b/binutils/ChangeLog index d5b515f..0b6a712 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,5 +1,9 @@ 2017-04-25 Maciej W. Rozycki <macro@imgtec.com> + * readelf.c (process_mips_specific): Remove null GOT data check. + +2017-04-25 Maciej W. Rozycki <macro@imgtec.com> + * testsuite/binutils-all/mips/mips16-alias.d: New test. * testsuite/binutils-all/mips/mips16-noalias.d: New test. * testsuite/binutils-all/mips/mips16-alias.s: New test source. diff --git a/binutils/readelf.c b/binutils/readelf.c index e575667..d4c4137 100644 --- a/binutils/readelf.c +++ b/binutils/readelf.c @@ -15483,8 +15483,7 @@ process_mips_specific (FILE * file) data = (unsigned char *) get_data (NULL, file, offset, global_end - pltgot, 1, _("Global Offset Table data")); - if (data == NULL) - return FALSE; + /* PR 12855: Null data is handled gracefully throughout. */ data_end = data + (global_end - pltgot); printf (_("\nPrimary GOT:\n")); |