diff options
author | Cory Fields <cory@coryfields.com> | 2013-11-22 14:54:33 +0000 |
---|---|---|
committer | Nick Clifton <nickc@redhat.com> | 2013-11-22 14:55:56 +0000 |
commit | 0cb112f7400187275da81a05a9ad0534f1430139 (patch) | |
tree | d5f66a797c7e83233320057c2ea9809266c3cffc /binutils | |
parent | 194cca41192efa65f710967e3149bbc813c12b22 (diff) | |
download | fsf-binutils-gdb-0cb112f7400187275da81a05a9ad0534f1430139.zip fsf-binutils-gdb-0cb112f7400187275da81a05a9ad0534f1430139.tar.gz fsf-binutils-gdb-0cb112f7400187275da81a05a9ad0534f1430139.tar.bz2 |
* windres.c (define_resource): Use zero for timestamp, making
output deterministic. time.h include is no longer needed.
* resres.c (res_append_resource): Likewise.
* pe-dll.c (fill_edata): Only use a real timestamp if
--insert-timestamp was used.
* emultempl/pe.em: Add the --insert-timestamp option.
* emultempl/pep.em: Likewise for 64bit.
* ld.texinfo: Document the --insert-timestamp option.
* libcoff-in.h: Add insert_timestamp flag to the pe_data struct.
* libcoff.h: Regenerate.
* peXXigen.c (_bfd_XXi_only_swap_filehdr_out): Only use a real
timestamp if --insert-timestamp was used.
Diffstat (limited to 'binutils')
-rw-r--r-- | binutils/ChangeLog | 6 | ||||
-rw-r--r-- | binutils/resres.c | 16 | ||||
-rw-r--r-- | binutils/windres.c | 15 |
3 files changed, 15 insertions, 22 deletions
diff --git a/binutils/ChangeLog b/binutils/ChangeLog index cc9c6f9..ca2a322 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,3 +1,9 @@ +2013-11-22 Cory Fields <cory@coryfields.com> + + * windres.c (define_resource): Use zero for timestamp, making + output deterministic. time.h include is no longer needed. + * resres.c (res_append_resource): Likewise. + 2013-11-13 Martin Mitas <mity@morous.org> * rescoff.c (write_coff_file): Use 64-bit alignment for resource diff --git a/binutils/resres.c b/binutils/resres.c index ff95cb5..84f956f 100644 --- a/binutils/resres.c +++ b/binutils/resres.c @@ -1,6 +1,5 @@ /* resres.c: read_res_file and write_res_file implementation for windres. - Copyright 1998, 1999, 2001, 2002, 2005, 2007, 2008, 2011 - Free Software Foundation, Inc. + Copyright 1998-2013 Free Software Foundation, Inc. Written by Anders Norlander <anorland@hem2.passagen.se>. Rewritten by Kai Tietz, Onevision. @@ -32,7 +31,6 @@ #include "windres.h" #include <assert.h> -#include <time.h> static rc_uint_type write_res_directory (windres_bfd *, rc_uint_type, const rc_res_directory *, const rc_res_id *, @@ -660,17 +658,13 @@ res_append_resource (rc_res_directory **res_dirs, rc_res_resource *resource, if (*res_dirs == NULL) { - static unsigned long timeval; - - /* Use the same timestamp for every resource created in a - single run. */ - if (timeval == 0) - timeval = time (NULL); - *res_dirs = ((rc_res_directory *) res_alloc (sizeof (rc_res_directory))); + (*res_dirs)->characteristics = 0; - (*res_dirs)->time = timeval; + /* Using a real timestamp only serves to create non-deterministic + results. Use zero instead. */ + (*res_dirs)->time = 0; (*res_dirs)->major = 0; (*res_dirs)->minor = 0; (*res_dirs)->entries = NULL; diff --git a/binutils/windres.c b/binutils/windres.c index 7de73ef..64afb3a 100644 --- a/binutils/windres.c +++ b/binutils/windres.c @@ -1,6 +1,5 @@ /* windres.c -- a program to manipulate Windows resources - Copyright 1997, 1998, 1999, 2000, 2001, 2002, 2003, 2004, 2005, 2007, 2008, - 2009, 2011, 2012 Free Software Foundation, Inc. + Copyright 1997-2013 Free Software Foundation, Inc. Written by Ian Lance Taylor, Cygnus Support. Rewritten by Kai Tietz, Onevision. @@ -37,7 +36,6 @@ #include "sysdep.h" #include <assert.h> -#include <time.h> #include "bfd.h" #include "getopt.h" #include "bucomm.h" @@ -339,17 +337,12 @@ define_resource (rc_res_directory **resources, int cids, if (*resources == NULL) { - static unsigned int timeval; - - /* Use the same timestamp for every resource created in a - single run. */ - if (timeval == 0) - timeval = time (NULL); - *resources = ((rc_res_directory *) res_alloc (sizeof (rc_res_directory))); (*resources)->characteristics = 0; - (*resources)->time = timeval; + /* Using a real timestamp only serves to create non-deterministic + results. Use zero instead. */ + (*resources)->time = 0; (*resources)->major = 0; (*resources)->minor = 0; (*resources)->entries = NULL; |