diff options
| author | Nick Clifton <nickc@redhat.com> | 2017-06-26 13:25:41 +0100 |
|---|---|---|
| committer | Nick Clifton <nickc@redhat.com> | 2017-06-26 13:26:47 +0100 |
| commit | 0602cdad745472ed2561d8096a4bb021c8d0301d (patch) | |
| tree | a6b8702cf25fc021efe3b2ca038d6d97959e9d80 /binutils | |
| parent | a3aea05a66ec325ddd19b0c8dbe504958a295cd3 (diff) | |
| download | fsf-binutils-gdb-0602cdad745472ed2561d8096a4bb021c8d0301d.zip fsf-binutils-gdb-0602cdad745472ed2561d8096a4bb021c8d0301d.tar.gz fsf-binutils-gdb-0602cdad745472ed2561d8096a4bb021c8d0301d.tar.bz2 | |
Produce a consistent warning message when attempting to run a tool on a directory.
PR binutils/21659
* bucomm.c (get_file_size): Explicitly warn if the file is a
directory.
Diffstat (limited to 'binutils')
| -rw-r--r-- | binutils/ChangeLog | 6 | ||||
| -rw-r--r-- | binutils/bucomm.c | 2 |
2 files changed, 8 insertions, 0 deletions
diff --git a/binutils/ChangeLog b/binutils/ChangeLog index cc4003c..6810c22 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,3 +1,9 @@ +2017-06-26 Nick Clifton <nickc@redhat.com> + + PR binutils/21659 + * bucomm.c (get_file_size): Explicitly warn if the file is a + directory. + 2017-06-24 Thomas Preud'homme <thomas.preudhomme@arm.com> * readelf.c (arm_attr_tag_CPU_arch): Fill value for ARMv8-R. diff --git a/binutils/bucomm.c b/binutils/bucomm.c index fd6f356..5a0b634 100644 --- a/binutils/bucomm.c +++ b/binutils/bucomm.c @@ -598,6 +598,8 @@ get_file_size (const char * file_name) non_fatal (_("Warning: could not locate '%s'. reason: %s"), file_name, strerror (errno)); } + else if (S_ISDIR (statbuf.st_mode)) + non_fatal (_("Warning: '%s' is a directory"), file_name); else if (! S_ISREG (statbuf.st_mode)) non_fatal (_("Warning: '%s' is not an ordinary file"), file_name); else if (statbuf.st_size < 0) |