diff options
| author | Fangrui Song <i@maskray.me> | 2022-06-25 10:44:26 -0700 |
|---|---|---|
| committer | H.J. Lu <hjl.tools@gmail.com> | 2022-07-19 08:41:52 -0700 |
| commit | d19a265487eda186b6977d9d15648cda9fad3298 (patch) | |
| tree | b5a00da21278e636f234bd0c9c002f463ac1533e /bfd | |
| parent | e9061058b4fb26a6b4a7243f5dca1eb9066f2671 (diff) | |
| download | fsf-binutils-gdb-d19a265487eda186b6977d9d15648cda9fad3298.zip fsf-binutils-gdb-d19a265487eda186b6977d9d15648cda9fad3298.tar.gz fsf-binutils-gdb-d19a265487eda186b6977d9d15648cda9fad3298.tar.bz2 | |
x86: Make protected symbols local for -shared
Call _bfd_elf_symbol_refs_local_p with local_protected==true. This has
2 noticeable effects for -shared:
* GOT-generating relocations referencing a protected data symbol no
longer lead to a GLOB_DAT (similar to a hidden symbol).
* Direct access relocations (e.g. R_X86_64_PC32) no longer has the
confusing diagnostic below.
__attribute__((visibility("protected"))) void *foo() {
return (void *)foo;
}
// gcc -fpic -shared -fuse-ld=bfd
relocation R_X86_64_PC32 against protected symbol `foo' can not be used when making a shared object
The new behavior matches arm, aarch64 (commit
83c325007c5599fa9b60b8d5f7b84842160e1d1b), and powerpc ports, and other
linkers: gold and ld.lld.
Note: if some code tries to use direct access relocations to take the
address of foo, the pointer equality will break, but the error should be
reported on the executable link, not on the innocent shared object link.
glibc 2.36 will give a warning at relocation resolving time.
With this change, `#define elf_backend_extern_protected_data 1` is no
longer effective. Just remove it.
Remove the test "Run protected-func-1 without PIE" since -fno-pic
address taken operation in the executable doesn't work with protected
symbol in a shared object by default. Similarly, remove
protected-data-1a and protected-data-1b. protected-data-1b can be made
working by removing HAVE_LD_PIE_COPYRELOC from GCC
(https://sourceware.org/pipermail/gcc-patches/2022-June/596678.html).
Diffstat (limited to 'bfd')
| -rw-r--r-- | bfd/elf32-i386.c | 1 | ||||
| -rw-r--r-- | bfd/elf64-x86-64.c | 1 | ||||
| -rw-r--r-- | bfd/elfxx-x86.c | 2 |
3 files changed, 1 insertions, 3 deletions
diff --git a/bfd/elf32-i386.c b/bfd/elf32-i386.c index 3d39dc0..04a972e 100644 --- a/bfd/elf32-i386.c +++ b/bfd/elf32-i386.c @@ -4426,7 +4426,6 @@ elf_i386_link_setup_gnu_properties (struct bfd_link_info *info) #define elf_backend_got_header_size 12 #define elf_backend_plt_alignment 4 #define elf_backend_dtrel_excludes_plt 1 -#define elf_backend_extern_protected_data 1 #define elf_backend_caches_rawsize 1 #define elf_backend_want_dynrelro 1 diff --git a/bfd/elf64-x86-64.c b/bfd/elf64-x86-64.c index 48ca630..3abc68a 100644 --- a/bfd/elf64-x86-64.c +++ b/bfd/elf64-x86-64.c @@ -5277,7 +5277,6 @@ elf_x86_64_special_sections[]= #define elf_backend_got_header_size (GOT_ENTRY_SIZE*3) #define elf_backend_rela_normal 1 #define elf_backend_plt_alignment 4 -#define elf_backend_extern_protected_data 1 #define elf_backend_caches_rawsize 1 #define elf_backend_dtrel_excludes_plt 1 #define elf_backend_want_dynrelro 1 diff --git a/bfd/elfxx-x86.c b/bfd/elfxx-x86.c index acb2cc8..18f3d33 100644 --- a/bfd/elfxx-x86.c +++ b/bfd/elfxx-x86.c @@ -3094,7 +3094,7 @@ _bfd_x86_elf_link_symbol_references_local (struct bfd_link_info *info, 2. When building executable, there is no dynamic linker. Or 3. or "-z nodynamic-undefined-weak" is used. */ - if (SYMBOL_REFERENCES_LOCAL (info, h) + if (_bfd_elf_symbol_refs_local_p (h, info, 1) || (h->root.type == bfd_link_hash_undefweak && (ELF_ST_VISIBILITY (h->other) != STV_DEFAULT || (bfd_link_executable (info) |