diff options
| author | Richard Henderson <rth@redhat.com> | 2001-09-09 06:58:06 +0000 |
|---|---|---|
| committer | Richard Henderson <rth@redhat.com> | 2001-09-09 06:58:06 +0000 |
| commit | f16fbd61d9f5f2940137ea1aea523652964723eb (patch) | |
| tree | 212bc914ab03a13df5e595580fceda9dff772570 /bfd | |
| parent | 5ac3ea58917bfcd7eebfdfbe666ad0f904814390 (diff) | |
| download | fsf-binutils-gdb-f16fbd61d9f5f2940137ea1aea523652964723eb.zip fsf-binutils-gdb-f16fbd61d9f5f2940137ea1aea523652964723eb.tar.gz fsf-binutils-gdb-f16fbd61d9f5f2940137ea1aea523652964723eb.tar.bz2 | |
* elf64-alpha.c (elf64_alpha_relocate_section): Soft fail
relocation errors. Fail gp-relative relocations against
dynamic symbols.
Diffstat (limited to 'bfd')
| -rw-r--r-- | bfd/ChangeLog | 6 | ||||
| -rw-r--r-- | bfd/elf64-alpha.c | 21 |
2 files changed, 24 insertions, 3 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog index fba495d..c17ff62 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,9 @@ +2001-09-08 Richard Henderson <rth@redhat.com> + + * elf64-alpha.c (elf64_alpha_relocate_section): Soft fail + relocation errors. Fail gp-relative relocations against + dynamic symbols. + 2001-09-08 Alan Modra <amodra@bigpond.net.au> * elf32-i386.c (elf_i386_relocate_section): Check !DEF_REGULAR diff --git a/bfd/elf64-alpha.c b/bfd/elf64-alpha.c index acd514c..9e22023 100644 --- a/bfd/elf64-alpha.c +++ b/bfd/elf64-alpha.c @@ -3241,6 +3241,7 @@ elf64_alpha_relocate_section (output_bfd, info, input_bfd, input_section, asection *sec, *sgot, *srel, *srelgot; bfd *dynobj, *gotobj; bfd_vma gp; + boolean ret_val = true; srelgot = srel = NULL; symtab_hdr = &elf_tdata (input_bfd)->symtab_hdr; @@ -3389,7 +3390,7 @@ elf64_alpha_relocate_section (output_bfd, info, input_bfd, input_section, input_section, rel->r_offset, (!info->shared || info->no_undefined || ELF_ST_VISIBILITY (h->root.other))))) - return false; + ret_val = false; relocation = 0; } } @@ -3488,11 +3489,25 @@ elf64_alpha_relocate_section (output_bfd, info, input_bfd, input_section, case R_ALPHA_GPREL16: case R_ALPHA_GPREL32: case R_ALPHA_GPRELLOW: + if (h && alpha_elf_dynamic_symbol_p (&h->root, info)) + { + (*_bfd_error_handler) + (_("%s: gp-relative relocation against dynamic symbol %s"), + bfd_get_filename (input_bfd), h->root.root.root.string); + ret_val = false; + } BFD_ASSERT(gp != 0); relocation -= gp; goto default_reloc; case R_ALPHA_GPRELHIGH: + if (h && alpha_elf_dynamic_symbol_p (&h->root, info)) + { + (*_bfd_error_handler) + (_("%s: gp-relative relocation against dynamic symbol %s"), + bfd_get_filename (input_bfd), h->root.root.root.string); + ret_val = false; + } BFD_ASSERT(gp != 0); relocation -= gp; relocation += addend; @@ -3609,7 +3624,7 @@ elf64_alpha_relocate_section (output_bfd, info, input_bfd, input_section, if (! ((*info->callbacks->reloc_overflow) (info, name, howto->name, (bfd_vma) 0, input_bfd, input_section, rel->r_offset))) - return false; + ret_val = false; } break; @@ -3619,7 +3634,7 @@ elf64_alpha_relocate_section (output_bfd, info, input_bfd, input_section, } } - return true; + return ret_val; } /* Finish up dynamic symbol handling. We set the contents of various |