aboutsummaryrefslogtreecommitdiff
path: root/bfd
diff options
context:
space:
mode:
authorSimon Marchi <simon.marchi@efficios.com>2022-01-15 22:13:07 -0500
committerSimon Marchi <simon.marchi@polymtl.ca>2022-01-17 23:14:57 -0500
commit0c80c644641f67b18661a63b19c47074b308bc18 (patch)
treec4600f8d51caaf6385272c67bc14ce6add4a24db /bfd
parente2c0149e8b0ce12accb8f4b02cbbeff3e91e4737 (diff)
downloadfsf-binutils-gdb-0c80c644641f67b18661a63b19c47074b308bc18.zip
fsf-binutils-gdb-0c80c644641f67b18661a63b19c47074b308bc18.tar.gz
fsf-binutils-gdb-0c80c644641f67b18661a63b19c47074b308bc18.tar.bz2
bfd/elf64-ppc.c: fix clang -Wbitwise-instead-of-logical warning in ppc64_elf_check_init_fini
I see this error with clang-14: CC elf64-ppc.lo /home/smarchi/src/binutils-gdb/bfd/elf64-ppc.c:13131:11: error: use of bitwise '&' with boolean operands [-Werror,-Wbitwise-instead-of-logical] return (check_pasted_section (info, ".init") ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Fix by replacing & with &&. But given that the check_pasted_section function has side-effects and we want to make sure both calls are made, assign to temporary variables before evaluating the `&&`. Change-Id: I849e1b2401bea5f4d8ef3ab9af99ba9e3ef42490
Diffstat (limited to 'bfd')
-rw-r--r--bfd/elf64-ppc.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c
index 0f94579..923c7a3 100644
--- a/bfd/elf64-ppc.c
+++ b/bfd/elf64-ppc.c
@@ -13202,8 +13202,10 @@ check_pasted_section (struct bfd_link_info *info, const char *name)
bool
ppc64_elf_check_init_fini (struct bfd_link_info *info)
{
- return (check_pasted_section (info, ".init")
- & check_pasted_section (info, ".fini"));
+ bool ret1 = check_pasted_section (info, ".init");
+ bool ret2 = check_pasted_section (info, ".fini");
+
+ return ret1 && ret2;
}
/* See whether we can group stub sections together. Grouping stub