diff options
| author | Nick Clifton <nickc@redhat.com> | 2007-06-29 14:36:21 +0000 |
|---|---|---|
| committer | Nick Clifton <nickc@redhat.com> | 2007-06-29 14:36:21 +0000 |
| commit | 32e8a950c4e551038786bc4980dcb9fbfb8384b0 (patch) | |
| tree | 38c7ee8e71cf992989bc122da371de74e94c0334 /bfd | |
| parent | 3d3d428f048cd724b634cb0252dd187f3fabc627 (diff) | |
| download | fsf-binutils-gdb-32e8a950c4e551038786bc4980dcb9fbfb8384b0.zip fsf-binutils-gdb-32e8a950c4e551038786bc4980dcb9fbfb8384b0.tar.gz fsf-binutils-gdb-32e8a950c4e551038786bc4980dcb9fbfb8384b0.tar.bz2 | |
* bfd.c (bfd_demangle): Plug memory leak (Coverity).
Diffstat (limited to 'bfd')
| -rw-r--r-- | bfd/ChangeLog | 4 | ||||
| -rw-r--r-- | bfd/bfd.c | 12 |
2 files changed, 10 insertions, 6 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 33313c0..ad71032 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,7 @@ +2007-06-29 Michael Snyder <msnyder@svkmacdonelllnx> + + * bfd.c (bfd_demangle): Plug memory leak (Coverity). + 2007-06-29 M R Swami Reddy <MR.Swami.Reddy@nsc.com> * Makefile.am: Add cr16 related entry @@ -1773,12 +1773,12 @@ bfd_demangle (bfd *abfd, const char *name, int options) suf = res + len; suf_len = strlen (suf) + 1; final = bfd_malloc (pre_len + len + suf_len); - if (final == NULL) - return NULL; - - memcpy (final, pre, pre_len); - memcpy (final + pre_len, res, len); - memcpy (final + pre_len + len, suf, suf_len); + if (final != NULL) + { + memcpy (final, pre, pre_len); + memcpy (final + pre_len, res, len); + memcpy (final + pre_len + len, suf, suf_len); + } free (res); res = final; } |