aboutsummaryrefslogtreecommitdiff
path: root/bfd
diff options
context:
space:
mode:
authorClaudiu Zissulescu <claziss@synopsys.com>2016-02-29 16:07:48 +0100
committerClaudiu Zissulescu <claziss@synopsys.com>2016-02-29 16:07:48 +0100
commit7e4588997ebdddefc48d8be2d51a715822817c0e (patch)
treefc5f40d68dd6106dedd82a944df45d7f0986f424 /bfd
parent63aef214ab4826785d35d8dead591d40e402de98 (diff)
downloadfsf-binutils-gdb-7e4588997ebdddefc48d8be2d51a715822817c0e.zip
fsf-binutils-gdb-7e4588997ebdddefc48d8be2d51a715822817c0e.tar.gz
fsf-binutils-gdb-7e4588997ebdddefc48d8be2d51a715822817c0e.tar.bz2
[ARC] General fixes.
bfd/ 2016-02-29 Cupertino Miranda <Cupertino.Miranda@synopsys.com> * elf32-arc.c (arc_elf_final_write_processing): Add condition to the flag change. (elf_arc_relocate_section): Fixes and conditions to support PIE. Assert for code sections dynamic relocs. gas/ 2016-02-29 Claudiu Zissulescu <Claudiu.Zissulescu@synopsys.com> * config/tc-arc.c: Enable code density instructions for ARC EM. ld/ 2016-02-29 Cupertino Miranda <Cupertino.Miranda@synopsys.com> * scripttempl/arclinux.sc: Force .tdata and .tbss to always be generated.
Diffstat (limited to 'bfd')
-rw-r--r--bfd/ChangeLog7
-rw-r--r--bfd/elf32-arc.c28
2 files changed, 29 insertions, 6 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 8339eae..5d39624 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,10 @@
+2016-02-29 Cupertino Miranda <Cupertino.Miranda@synopsys.com>
+
+ * elf32-arc.c (arc_elf_final_write_processing): Add condition to
+ the flag change.
+ (elf_arc_relocate_section): Fixes and conditions to support PIE.
+ Assert for code sections dynamic relocs.
+
2016-02-26 Renlin Li <renlin.li@arm.com>
* elfnn-aarch64.c (elfNN_aarch64_howto_table): Fix signed overflow
diff --git a/bfd/elf32-arc.c b/bfd/elf32-arc.c
index 8ffc23a..9993478 100644
--- a/bfd/elf32-arc.c
+++ b/bfd/elf32-arc.c
@@ -688,10 +688,11 @@ arc_elf_final_write_processing (bfd * abfd,
default:
abort ();
}
+ if ((elf_elfheader (abfd)->e_flags & EF_ARC_MACH) == EF_ARC_CPU_GENERIC)
+ elf_elfheader (abfd)->e_flags |= val;
- elf_elfheader (abfd)->e_flags &= ~EF_ARC_MACH;
- elf_elfheader (abfd)->e_flags |= val;
elf_elfheader (abfd)->e_machine = emf;
+
/* Record whatever is the current syscall ABI version. */
elf_elfheader (abfd)->e_flags |= E_ARC_OSABI_CURRENT;
}
@@ -1319,14 +1320,24 @@ elf_arc_relocate_section (bfd * output_bfd,
}
else if (is_reloc_for_PLT (howto))
{
+ /* Fail if it is linking for PIE and the symbol is
+ undefined. */
+ if (bfd_link_executable (info)
+ && !(*info->callbacks->undefined_symbol)
+ (info, h->root.root.string, input_bfd, input_section,
+ rel->r_offset, TRUE))
+ {
+ return FALSE;
+ }
reloc_data.sym_value = h->plt.offset;
reloc_data.sym_section = htab->splt;
reloc_data.should_relocate = TRUE;
}
- else if (!(*info->callbacks->undefined_symbol)
+ else if (!bfd_link_pic (info)
+ && !(*info->callbacks->undefined_symbol)
(info, h->root.root.string, input_bfd, input_section,
- rel->r_offset,!bfd_link_pic (info)))
+ rel->r_offset, TRUE))
{
return FALSE;
}
@@ -1443,7 +1454,7 @@ elf_arc_relocate_section (bfd * output_bfd,
case R_ARC_32_ME:
case R_ARC_PC32:
case R_ARC_32_PCREL:
- if (bfd_link_pic (info)
+ if (bfd_link_pic (info) && !bfd_link_pie (info)
&& ((r_type != R_ARC_PC32 && r_type != R_ARC_32_PCREL)
|| (h != NULL
&& h->dynindx != -1
@@ -1509,6 +1520,11 @@ elf_arc_relocate_section (bfd * output_bfd,
else
{
BFD_ASSERT (h->dynindx != -1);
+
+ /* This type of dynamic relocation cannot be created
+ for code sections. */
+ BFD_ASSERT ((input_section->flags & SEC_CODE) == 0);
+
if ((input_section->flags & SEC_ALLOC) != 0)
relocate = FALSE;
else
@@ -1715,7 +1731,7 @@ elf_arc_check_relocs (bfd * abfd,
/* FALLTHROUGH */
case R_ARC_PC32:
case R_ARC_32_PCREL:
- if (bfd_link_pic (info)
+ if (bfd_link_pic (info) && !bfd_link_pie (info)
&& ((r_type != R_ARC_PC32 && r_type != R_ARC_32_PCREL)
|| (h != NULL
&& h->dynindx != -1