diff options
author | Alan Modra <amodra@gmail.com> | 2002-01-05 13:11:33 +0000 |
---|---|---|
committer | Alan Modra <amodra@gmail.com> | 2002-01-05 13:11:33 +0000 |
commit | 9e7b37b31f29ad3b8321d15e589ed5de550c56d3 (patch) | |
tree | 45c0765ba86e10dfd9d2ad45edc64de1be7a3a31 /bfd/rs6000-core.c | |
parent | 3f0a7f7f7351fe42312c4c960abdd0b69f1d2e0c (diff) | |
download | fsf-binutils-gdb-9e7b37b31f29ad3b8321d15e589ed5de550c56d3.zip fsf-binutils-gdb-9e7b37b31f29ad3b8321d15e589ed5de550c56d3.tar.gz fsf-binutils-gdb-9e7b37b31f29ad3b8321d15e589ed5de550c56d3.tar.bz2 |
* section.c (bfd_section_init): Remove unnecessary initialisations.
(bfd_section_list_clear): New function.
(bfd_section_list_remove, bfd_section_list_insert): New macros.
(_bfd_strip_section_from_output): Use them.
* coffcode.h (coff_set_alignment_hook): Likewise.
* elf32-mips.c (_bfd_mips_elf_final_link): Likewise.
* elf64-mips.c (mips_elf64_final_link): Likewise.
* elf64-mmix.c (mmix_elf_final_link): Likewise.
* sunos.c (sunos_add_dynamic_symbols): Likewise.
* xcofflink.c (_bfd_xcoff_bfd_final_link): Likewise.
* bfd-in2.h: Regenerate.
* netbsd-core.c (netbsd_core_file_p): Use bfd_make_section_anyway
rather than doing our own section handling. Clean up after errors
with bfd_release and bfd_section_list_clear. Handle unexpected
flags.
* aoutf1.h (sunos4_core_file_p): Likewise.
* aix386-core.c (aix386_core_file_p): Likewise.
* cisco-core.c (cisco_core_file_validate): Likewise.
* ptrace-core.c (ptrace_unix_core_file_p): Likewise.
* trad-core.c (trad_unix_core_file_p): Likewise.
* hppabsd-core.c (hppabsd_core_core_file_p): Clean up after errors
with bfd_release and bfd_section_list_clear.
* hpux-core.c (hpux_core_core_file_p): Likewise.
* irix-core.c (irix_core_core_file_p): Likewise.
* lynx-core.c (lynx_core_file_p): Likewise.
* osf-core.c (osf_core_core_file_p): Likewise.
* rs6000-core.c (rs6000coff_core_p): Likewise.
* sco5-core.c (sco5_core_file_p): Likewise.
Diffstat (limited to 'bfd/rs6000-core.c')
-rw-r--r-- | bfd/rs6000-core.c | 30 |
1 files changed, 18 insertions, 12 deletions
diff --git a/bfd/rs6000-core.c b/bfd/rs6000-core.c index e6405f9..19ff4a4 100644 --- a/bfd/rs6000-core.c +++ b/bfd/rs6000-core.c @@ -1,6 +1,6 @@ /* IBM RS/6000 "XCOFF" back-end for BFD. Copyright 1990, 1991, 1992, 1993, 1994, 1995, 1996, 1997, 1998, 2000, - 2001 + 2001, 2002 Free Software Foundation, Inc. FIXME: Can someone provide a transliteration of this name into ASCII? Using the following chars caused a compiler warning on HIUX (so I replaced @@ -462,13 +462,13 @@ rs6000coff_core_p (abfd) if (!make_bfd_asection (abfd, ".stack", SEC_ALLOC | SEC_LOAD | SEC_HAS_CONTENTS, c_size, c_stackend - c_size, c_stack)) - return NULL; + goto fail; /* .reg section for all registers. */ if (!make_bfd_asection (abfd, ".reg", SEC_HAS_CONTENTS, c_regsize, (bfd_vma) 0, c_regoff)) - return NULL; + goto fail; /* .ldinfo section. To actually find out how long this section is in this particular @@ -477,7 +477,7 @@ rs6000coff_core_p (abfd) if (!make_bfd_asection (abfd, ".ldinfo", SEC_HAS_CONTENTS, c_lsize, (bfd_vma) 0, c_loader)) - return NULL; + goto fail; #ifndef CORE_VERSION_1 /* .data section if present. @@ -494,7 +494,7 @@ rs6000coff_core_p (abfd) (bfd_vma) CDATA_ADDR (core.old.c_u.u_dsize), c_stack + c_size)) - return NULL; + goto fail; } #endif @@ -536,7 +536,7 @@ rs6000coff_core_p (abfd) c_datasize, (bfd_vma) CDATA_ADDR (c_datasize), c_data)) - return NULL; + goto fail; } /* .data sections from loaded objects. */ @@ -548,9 +548,9 @@ rs6000coff_core_p (abfd) while (1) { if (bfd_seek (abfd, c_loader, SEEK_SET) != 0) - return NULL; + goto fail; if (bfd_bread (&ldinfo, size, abfd) != size) - return NULL; + goto fail; if (proc64) { @@ -571,7 +571,7 @@ rs6000coff_core_p (abfd) if (!make_bfd_asection (abfd, ".data", SEC_ALLOC | SEC_LOAD | SEC_HAS_CONTENTS, ldi_datasize, ldi_dataorg, ldi_core)) - return NULL; + goto fail; if (ldi_next == 0) break; @@ -584,7 +584,7 @@ rs6000coff_core_p (abfd) bfd_size_type i; if (bfd_seek (abfd, c_vmm, SEEK_SET) != 0) - return NULL; + goto fail; for (i = 0; i < c_vmregions; i++) { @@ -595,7 +595,7 @@ rs6000coff_core_p (abfd) size = CORE_NEW (core) ? sizeof (vminfo.new) : sizeof (vminfo.old); if (bfd_bread (&vminfo, size, abfd) != size) - return NULL; + goto fail; if (CORE_NEW (core)) { @@ -615,13 +615,19 @@ rs6000coff_core_p (abfd) SEC_ALLOC | SEC_LOAD | SEC_HAS_CONTENTS, vminfo_size, vminfo_addr, vminfo_offset)) - return NULL; + goto fail; } } } #endif return abfd->xvec; /* This is garbage for now. */ + + fail: + bfd_release (abfd, abfd->tdata.any); + abfd->tdata.any = NULL; + bfd_section_list_clear (abfd); + return NULL; } /* Return `true' if given core is from the given executable. */ |