aboutsummaryrefslogtreecommitdiff
path: root/bfd/pei-x86_64.c
diff options
context:
space:
mode:
authorNick Clifton <nickc@redhat.com>2014-11-18 14:40:05 +0000
committerNick Clifton <nickc@redhat.com>2014-11-18 14:40:05 +0000
commit6937bb54a9c3ddc7ba330bc18af76f8dbe856ac3 (patch)
treeef3620d4de908919f540cbb095a7f9f62da9d72c /bfd/pei-x86_64.c
parentde84aee38c50fd306876cdbf92007afaacbfab4d (diff)
downloadfsf-binutils-gdb-6937bb54a9c3ddc7ba330bc18af76f8dbe856ac3.zip
fsf-binutils-gdb-6937bb54a9c3ddc7ba330bc18af76f8dbe856ac3.tar.gz
fsf-binutils-gdb-6937bb54a9c3ddc7ba330bc18af76f8dbe856ac3.tar.bz2
More fixes for illegal memory accesses exposed by fuzzed binaries.
PR binutils/17512 * peXXIgen.c (pe_print_pdata): Fail if the section's virtual size is larger than its real size. (rsrc_print_section): Fix off-by-one error checking for overflow. * pei-x86_64.c (pex64_bfd_print_pdata): Handle empty unwind sections. * dwarf.c (get_encoded_value): Warn and return if the encoded value is more than 64-bits long. (SAFE_BYTE_GET): Do not attempt to read more than 64-bits. (process_extended_line_op): Add more range checks. (decode_location_expression): Use the return value from display_block. Add more range checks. (read_debug_line_header): Add range check. (display_debug_lines_raw): Add range checks. (display_debug_frames): Silently skip multiple zero terminators. Add range checks. (process_cu_tu_index): Check for non-existant or empty sections. Use SAFE_BYTE_GET instead of byte_get.
Diffstat (limited to 'bfd/pei-x86_64.c')
-rw-r--r--bfd/pei-x86_64.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/bfd/pei-x86_64.c b/bfd/pei-x86_64.c
index 48554d3..11ee73a 100644
--- a/bfd/pei-x86_64.c
+++ b/bfd/pei-x86_64.c
@@ -464,6 +464,12 @@ pex64_bfd_print_pdata (bfd *abfd, void *vfile)
return TRUE;
stop = pei_section_data (abfd, pdata_section)->virt_size;
+ /* PR 17512: file: 005-181405-0.004. */
+ if (stop == 0 || pdata_section->size == 0)
+ {
+ fprintf (file, _("No unwind data in .pdata section\n"));
+ return TRUE;
+ }
if ((stop % onaline) != 0)
fprintf (file,
_("warning: .pdata section size (%ld) is not a multiple of %d\n"),
@@ -490,6 +496,7 @@ pex64_bfd_print_pdata (bfd *abfd, void *vfile)
if (i + PDATA_ROW_SIZE > stop)
break;
+
pex64_get_runtime_function (abfd, &rf, &pdata[i]);
if (rf.rva_BeginAddress == 0 && rf.rva_EndAddress == 0