diff options
author | Alan Modra <amodra@gmail.com> | 2020-12-17 07:44:48 +1030 |
---|---|---|
committer | Alan Modra <amodra@gmail.com> | 2020-12-18 10:34:16 +1030 |
commit | 7f3a18cfb58deb36e05469d94e7b9e48b19d90af (patch) | |
tree | fdcaf3f90aab305c07bb75189d9db56db67c4dbe /bfd/elf32-m32r.c | |
parent | 3ece0b95273fafe20fface5be0b70667eaf7a127 (diff) | |
download | fsf-binutils-gdb-7f3a18cfb58deb36e05469d94e7b9e48b19d90af.zip fsf-binutils-gdb-7f3a18cfb58deb36e05469d94e7b9e48b19d90af.tar.gz fsf-binutils-gdb-7f3a18cfb58deb36e05469d94e7b9e48b19d90af.tar.bz2 |
Statically initialise target common sections
This tidies initialisation of target common sections, doing so using a
static initialiser rather than via code and deleting unnecessary
symbol_ptr_ptr variables (the one in asection is used instead).
The patch also initialises ecoff.c:bfd_debug_section using
BFD_FAKE_SECTION. That does change bfd_debug_section slightly,
output_section was NULL now bfd_debug_section, and symbol_ptr_ptr
was NULL now &bfd_debug_section.symbol, but I believe those changes
are safe.
bfd/
* ecoff.c (bfd_debug_section): Init using BFD_FAKE_SECTION.
(ecoff_scom_section, ecoff_scom_symbol): Statically init using
BFD_FAKE_SECTION and GLOBAL_SYM_INIT. Delete initialisation code.
(ecoff_scom_symbol_ptr): Delete.
* elf32-m32r.c (m32r_elf_scom_section, m32r_elf_scom_symbol),
(m32r_elf_scom_symbol_ptr),
* elf32-score.c (score_elf_scom_section, score_elf_scom_symbol),
(score_elf_scom_symbol_ptr),
* elf32-score7.c (score_elf_scom_section, score_elf_scom_symbol),
(score_elf_scom_symbol_ptr),
* elf32-tic6x.c (tic6x_elf_scom_section, tic6x_elf_scom_symbol),
(tic6x_elf_scom_symbol_ptr),
* elf32-v850.c (v850_elf_scom_section, v850_elf_scom_symbol),
(v850_elf_scom_symbol_ptr),
(v850_elf_tcom_section, v850_elf_tcom_symbol),
(v850_elf_tcom_symbol_ptr),
(v850_elf_zcom_section, v850_elf_zcom_symbol),
(v850_elf_zcom_symbol_ptr),
* elf64-mmix.c (mmix_elf_reg_section, mmix_elf_reg_section_symbol),
(mmix_elf_reg_section_symbol_ptr),
* elfxx-mips.c (mips_elf_scom_section, mips_elf_scom_symbol),
(mips_elf_scom_symbol_ptr): Likewise.
gas/
* ecoff.c (ecoff_frob_symbol): Rename scom_section to
ecoff_scom_section and statically initialise.
Diffstat (limited to 'bfd/elf32-m32r.c')
-rw-r--r-- | bfd/elf32-m32r.c | 20 |
1 files changed, 5 insertions, 15 deletions
diff --git a/bfd/elf32-m32r.c b/bfd/elf32-m32r.c index 533d662..46fb6c7 100644 --- a/bfd/elf32-m32r.c +++ b/bfd/elf32-m32r.c @@ -1337,8 +1337,11 @@ _bfd_m32r_elf_section_from_bfd_section (bfd *abfd ATTRIBUTE_UNUSED, _SDA_BASE. This is what we use for the small common section. This approach is copied from elf32-mips.c. */ static asection m32r_elf_scom_section; -static asymbol m32r_elf_scom_symbol; -static asymbol *m32r_elf_scom_symbol_ptr; +static const asymbol m32r_elf_scom_symbol = + GLOBAL_SYM_INIT (".scommon", &m32r_elf_scom_section); +static asection m32r_elf_scom_section = + BFD_FAKE_SECTION (m32r_elf_scom_section, &m32r_elf_scom_symbol, + ".scommon", 0, SEC_IS_COMMON | SEC_SMALL_DATA); /* Handle the special M32R section numbers that a symbol may use. */ @@ -1350,19 +1353,6 @@ _bfd_m32r_elf_symbol_processing (bfd *abfd ATTRIBUTE_UNUSED, asymbol *asym) switch (elfsym->internal_elf_sym.st_shndx) { case SHN_M32R_SCOMMON: - if (m32r_elf_scom_section.name == NULL) - { - /* Initialize the small common section. */ - m32r_elf_scom_section.name = ".scommon"; - m32r_elf_scom_section.flags = SEC_IS_COMMON | SEC_SMALL_DATA; - m32r_elf_scom_section.output_section = &m32r_elf_scom_section; - m32r_elf_scom_section.symbol = &m32r_elf_scom_symbol; - m32r_elf_scom_section.symbol_ptr_ptr = &m32r_elf_scom_symbol_ptr; - m32r_elf_scom_symbol.name = ".scommon"; - m32r_elf_scom_symbol.flags = BSF_SECTION_SYM; - m32r_elf_scom_symbol.section = &m32r_elf_scom_section; - m32r_elf_scom_symbol_ptr = &m32r_elf_scom_symbol; - } asym->section = &m32r_elf_scom_section; asym->value = elfsym->internal_elf_sym.st_size; break; |