aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlan Modra <amodra@gmail.com>2020-07-27 17:27:23 +0930
committerAlan Modra <amodra@gmail.com>2020-07-27 22:31:37 +0930
commit8fab9282e5d231faa9105eb48eca9c3d4d990c93 (patch)
tree8c33b92cc84ff85e718bedfb54a8b6a2d3c25702
parent344e66534e37ec576d35b24b2933c808fd4e3e9c (diff)
downloadfsf-binutils-gdb-8fab9282e5d231faa9105eb48eca9c3d4d990c93.zip
fsf-binutils-gdb-8fab9282e5d231faa9105eb48eca9c3d4d990c93.tar.gz
fsf-binutils-gdb-8fab9282e5d231faa9105eb48eca9c3d4d990c93.tar.bz2
Prevent strange "section mentioned in a -j option but not found"
"objdump -s -j .bss" results in a message that indicates objdump couldn't find a .bss section when present. Fix that. * objdump.c (dump_section): Don't return without calling process_section_p.
-rw-r--r--binutils/ChangeLog5
-rw-r--r--binutils/objdump.c4
2 files changed, 7 insertions, 2 deletions
diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index 68b8b2c..2522808 100644
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,8 @@
+2020-07-27 Alan Modra <amodra@gmail.com>
+
+ * objdump.c (dump_section): Don't return without calling
+ process_section_p.
+
2020-07-27 H.J. Lu <hongjiu.lu@intel.com>
* doc/binutils.texi: Replace preceeded with preceded.
diff --git a/binutils/objdump.c b/binutils/objdump.c
index 978d86c..79ef051 100644
--- a/binutils/objdump.c
+++ b/binutils/objdump.c
@@ -4283,10 +4283,10 @@ dump_section (bfd *abfd, asection *section, void *dummy ATTRIBUTE_UNUSED)
int count;
int width;
- if ((section->flags & SEC_HAS_CONTENTS) == 0)
+ if (! process_section_p (section))
return;
- if (! process_section_p (section))
+ if ((section->flags & SEC_HAS_CONTENTS) == 0)
return;
if ((datasize = bfd_section_size (section)) == 0)