diff options
| author | Kevin Buettner <kevinb@redhat.com> | 2021-06-09 19:52:08 -0700 |
|---|---|---|
| committer | Kevin Buettner <kevinb@redhat.com> | 2021-06-11 14:57:44 -0700 |
| commit | b8bd29a1575dcac0207ae6f20e7a83533093db7d (patch) | |
| tree | 6ad27724d0d6406496f944452e1caa84cd53b1dd | |
| parent | 72c4daa36a3d35d578533d208668eb3ff9e7708f (diff) | |
| download | fsf-binutils-gdb-b8bd29a1575dcac0207ae6f20e7a83533093db7d.zip fsf-binutils-gdb-b8bd29a1575dcac0207ae6f20e7a83533093db7d.tar.gz fsf-binutils-gdb-b8bd29a1575dcac0207ae6f20e7a83533093db7d.tar.bz2 | |
mi-sym-info.exp: Increase timeout for 114-symbol-info-functions
Loading libc.so's symbols increased the amount of time needed for
114-symbol-info-function to fetch symbols, causing a timeout during my
testing. I enclosed the entire block with a "with_timeout_factor 4",
which fixes the problem for me. (Using 2 also fixed it for me, but it
might not be enough when running this test on slower machines.)
gdb/testsuite/ChangeLog:
* gdb.mi/mi-sym-info.exp (114-symbol-info-function test): Increase
timeout.
| -rw-r--r-- | gdb/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gdb/testsuite/gdb.mi/mi-sym-info.exp | 56 |
2 files changed, 34 insertions, 27 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 5f9db54..6cb2ef2 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,5 +1,10 @@ 2021-06-11 Kevin Buettner <kevinb@redhat.com> + * gdb.mi/mi-sym-info.exp (114-symbol-info-function test): Increase + timeout. + +2021-06-11 Kevin Buettner <kevinb@redhat.com> + * gdb.base/print-symbol-loading.exp (proc test_load_shlib): Allow "Symbols already loaded for..." messages. diff --git a/gdb/testsuite/gdb.mi/mi-sym-info.exp b/gdb/testsuite/gdb.mi/mi-sym-info.exp index 18f8518..dcd6f7d 100644 --- a/gdb/testsuite/gdb.mi/mi-sym-info.exp +++ b/gdb/testsuite/gdb.mi/mi-sym-info.exp @@ -123,33 +123,35 @@ gdb_test_multiple $cmd $testname -prompt "${mi_gdb_prompt}$" { # (from the symbol table). There's often so much output output from # this command that we overflow expect's buffers, avoid this by # fetching the output piece by piece. -set testname "List all functions" -set cmd "114-symbol-info-functions --include-nondebug" -set state 0 -gdb_test_multiple $cmd ${testname} -prompt "${mi_gdb_prompt}$" { - -re "114\\^done,symbols=\{" { - if { $state == 0 } { set state 1 } - exp_continue - } - -re "debug=\\\[${symtab_re}" { - if { $state == 1 } { set state 2 } - exp_continue - } - -re ",${symtab_re}" { - exp_continue - } - -re "\\\],nondebug=\\\[" { - if { $state == 2 } { set state 3 } - exp_continue - } - -re "\{address=${qstr},name=${qstr}\}," { - exp_continue - } - -re "\{address=${qstr},name=${qstr}\}\\\]\}\r\n${mi_gdb_prompt}$" { - if { $state == 3 } { - pass $gdb_test_name - } else { - fail $gdb_test_name +with_timeout_factor 4 { + set testname "List all functions" + set cmd "114-symbol-info-functions --include-nondebug" + set state 0 + gdb_test_multiple $cmd ${testname} -prompt "${mi_gdb_prompt}$" { + -re "114\\^done,symbols=\{" { + if { $state == 0 } { set state 1 } + exp_continue + } + -re "debug=\\\[${symtab_re}" { + if { $state == 1 } { set state 2 } + exp_continue + } + -re ",${symtab_re}" { + exp_continue + } + -re "\\\],nondebug=\\\[" { + if { $state == 2 } { set state 3 } + exp_continue + } + -re "\{address=${qstr},name=${qstr}\}," { + exp_continue + } + -re "\{address=${qstr},name=${qstr}\}\\\]\}\r\n${mi_gdb_prompt}$" { + if { $state == 3 } { + pass $gdb_test_name + } else { + fail $gdb_test_name + } } } } |